not everything that starts with "java." or "jdk." is a system module about update4j

[mordechaim]

Ooh... Any alternative of asserting a module is a real jdk system module (without bundling all mod names as a collection in the framework).

[mordechaim]

Or indeed bundling is the best and I should settle with that? Is it guaranteed all JDK's have the exact same system modules? Will they not change across versions and jvm implementations? Or I can safely assume that at least java modules will not change and only check for all other mods starting with jdk?

[bei]

I would propose to just use a compiled in fixed map with the jdk major version as the key and the list of system modules as the value. After all the code just there does just a check it doesn't hurt when the list would be incomplete but it hurts the way it is now because java.mail is include in what is being checked against right now although it is not a system module and therefor you will get an error here right now although everything is Ok.

[mordechaim]

I'm leaning to just keep a set of module names. Existing modules will never be removed (from JDK 11 and furthur), only new might be added in the future. In that case I'll see how I will proceed.