Comments (8)
looks great thanks.
from comedy.
There is some work needed to be put in order to make this work, but I think it's a matter of couple of days. I was expecting this kind of request. Will try to do in nearest time.
from comedy.
Added support for custom loggers in v1.8.0. See example: https://github.com/untu/comedy-examples/blob/master/custom-logger-bunyan.js
from comedy.
I used your example and it worked great until I tried starting an actor in forked mode. I then got Error: Cannot serialize actor definition. I threw a console in and noticed it was the BunyanLoggerAdapter. I made sure to move all the requires into the class itself but that didn't seem to help so I switched it to use the module method of loading. That worked but with two problems. I now get a warning for:
Promise.defer is deprecated and will be removed in a future version. Use new Promise instead.
a lot and my second problem is I'm not sure how to pass in a name for the bunyan initialization.
from comedy.
I will look at Promise.defer
warnings.
As for logger name: in the example it was hard-coded into BunyanLoggerAdapter
. Clearly, this may be not what you want. My question is: how would you like this to be done instead?
from comedy.
Maybe a way to pass in customParameters as part of the configuration.
from comedy.
@aintnorest , I've implemented constructor parameters for custom logger. Please check forked-bunyan-logger
branch from comedy-examples repo together with custom-logger-params
branch from this repo and tell if it works for you.
As for Promise.defer
error - I could not reproduce it in forked-bunyan-logger
branch in examples even with current Comedy release. Please try that example with release version and tell if you are able to see Promise.defer
errors. If not, please send me your code example.
from comedy.
Fix released in v.2.1.0.
from comedy.
Related Issues (20)
- Configuration by environment HOT 3
- Supervision support? HOT 3
- Can Resource depends on another Resource? HOT 1
- "Error: externalFunction is not defined" in forked nodes HOT 3
- Location Transparency? HOT 3
- Promise.defer is deprecated warning HOT 5
- tsc compile error HOT 1
- Dependencies inside Resources in forked modules HOT 1
- TypeError: Cannot read property 'send' of undefined HOT 2
- Actor State Names
- hot config reloads do not consider actor custom parameters HOT 7
- ActorRef passing is somewhat limited.
- Sending the message 0 produces undefined for forked and threaded actors. HOT 3
- State of an actor passed into a forked actor does not get updated.
- DEPENDENCY: Winston failing on node 14 HOT 5
- Discussion: drop configuration loading
- Suggestion: drop bluebird and leverage async/await HOT 3
- Test dependencies in package HOT 2
- Vulnerability updates: underscore and winston HOT 1
- comedy in browser HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from comedy.