Coder Social home page Coder Social logo

Support for Yarn PnP about unplugin-icons HOT 6 CLOSED

bmulholland avatar bmulholland commented on September 21, 2024
Support for Yarn PnP

from unplugin-icons.

Comments (6)

antfu avatar antfu commented on September 21, 2024

I don't have interests in supporting PnP, nor taking the complexity. Maybe we could expose an array where you can tell explicitly what collections are available?

from unplugin-icons.

bmulholland avatar bmulholland commented on September 21, 2024

Yeah I was thinking of something like that. It feels like there's likely just a bit of explicit configuration that could side-step the whole problem. That would be both acceptable (to the end-user dev) and way easier to maintain (for you). I'd be happy to poke at doing something like this -- sounds like you already have an idea of what/where? Could you point me in the right direction of where that array would go?

from unplugin-icons.

bmulholland avatar bmulholland commented on September 21, 2024

Just to drop in my initial thought: use the customCollections code to provide an explicit mapping. I don't know if that could work?

from unplugin-icons.

antfu avatar antfu commented on September 21, 2024

Sure, feel free to send a PR and we could discuss with the implementation

from unplugin-icons.

bmulholland avatar bmulholland commented on September 21, 2024

I guess I buried my question. I don't know where to start with the PR :). Could you kindly point me to where the magic resolution of collections happens? Any place I could start? Context that could help me? Even a file name or a sentence or two of context?

Like I say, I don't even know if the right code is in this repository. I don't have time to wrap my head around the multiple repos involved, but can certainly start something if I know the right place to look...

from unplugin-icons.

bmulholland avatar bmulholland commented on September 21, 2024

I was right to be suspicious of whether the fix was in this repo: turns out this is the root cause.

Nothing for this package, so closing out.

from unplugin-icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.