Latest version breaks with unplugin-vue-components about unplugin-icons

[userquin]

@cyberalien there was a bug resolving icon component, check this pr #316 and linked issue

[amir20]

Looks like components.d.ts is no longer generated correctly.

diff --git a/assets/components.d.ts b/assets/components.d.ts
index e83dc2aa..852b1547 100644
--- a/assets/components.d.ts
+++ b/assets/components.d.ts
@@ -8,17 +8,8 @@ export {}
 declare module 'vue' {
   export interface GlobalComponents {
     BarChart: typeof import('./components/BarChart.vue')['default']
-    'Carbon:caretDown': typeof import('~icons/carbon/caret-down')['default']
-    'Carbon:circleSolid': typeof import('~icons/carbon/circle-solid')['default']
     'Carbon:information': typeof import('~icons/carbon/information')['default']
-    'Carbon:macShift': typeof import('~icons/carbon/mac-shift')['default']
-    'Carbon:star': typeof import('~icons/carbon/star')['default']
-    'Carbon:starFilled': typeof import('~icons/carbon/star-filled')['default']
     'Carbon:warning': typeof import('~icons/carbon/warning')['default']
-    'Cil:checkCircle': typeof import('~icons/cil/check-circle')['default']
-    'Cil:circle': typeof import('~icons/cil/circle')['default']
-    'Cil:columns': typeof import('~icons/cil/columns')['default']
-    'Cil:xCircle': typeof import('~icons/cil/x-circle')['default']
     ComplexLogItem: typeof import('./components/LogViewer/ComplexLogItem.vue')['default']
     ContainerHealth: typeof import('./components/LogViewer/ContainerHealth.vue')['default']
     ContainerPopup: typeof import('./components/LogViewer/ContainerPopup.vue')['default']
@@ -31,8 +22,6 @@ declare module 'vue' {
     Dropdown: typeof import('./components/common/Dropdown.vue')['default']
     FieldList: typeof import('./components/LogViewer/FieldList.vue')['default']
     FuzzySearchModal: typeof import('./components/FuzzySearchModal.vue')['default']
-    'Ic:sharpFindInPage': typeof import('~icons/ic/sharp-find-in-page')['default']
-    'Ic:sharpKeyboardReturn': typeof import('~icons/ic/sharp-keyboard-return')['default']
     InfiniteLoader: typeof import('./components/InfiniteLoader.vue')['default']
     KeyShortcut: typeof import('./components/common/KeyShortcut.vue')['default']
     LogActionsToolbar: typeof import('./components/LogViewer/LogActionsToolbar.vue')['default']

[userquin]

Are you using mdi and mdi-light collections? How are you using the icons?

[amir20]

I am using mdi like <mdi:light-chevron-left />. Has something else changed from 0.17.0 --> 0.17.1 that can break this?

[userquin]

Check last merged pr or last release in releases from root repo page

I Will check this tmr.

[userquin]

What collections do you have installed? There is a chevron-left in both mdi and mdi-light IIRC, maybe you only have mdi-light collection installed? If so you only need to replace it with <mdi-light:chevron-left />, my pr just fix a bug.

EDIT: there is no light-chevron-left icon in mdi nor mdi-light and you are using the mdi collection (: is use as separator, but csmelToKebab function replaces it with dash) nd that's why it is not working

[amir20]

This used to work before the patch. I tested by reverting. So I don't think it's something on my side.

[userquin]

I Will try to send a patch tomorrow, your icon works in previous version due to a bug parsing the tag, that icon doesnt exist in the mdi collection.

[amir20]

Hi @userquin you maybe right. I don't see light-chevron-left anymore on https://icon-sets.iconify.design/?query=light-chevron-left. Which is weird because it was there before. But I find it weird that it used to work and stopped working. If I revert, it works again. Perhaps it's a change with other deps.

[amir20]

It seems like all light-* icons have been removed. Not sure why. Feel free to close this. I am not sure why previous ever worked.

[userquin]

@amir20 yeah, it seems the light variants moved to mdi-light collection...

[cyberalien]

light- icons never existed in mdi set. mdi:light-chevron-left never existed. mdi-light:chevron-left though did exist.

I don't know why your code worked before, probably there was a bug in resolving icon sets.