Coder Social home page Coder Social logo

Comments (5)

jagger-harris avatar jagger-harris commented on August 30, 2024 1

I think we might be able to close this issue now with the new frontend.

from udao.

oslfmt avatar oslfmt commented on August 30, 2024

I would've imagined something more like: the html code this Grants component returns, returns another 2 child components, which are identical cards, maybe something like <CardContainer />. Each of these components takes a props, which are the activeGrants and inactiveGrants you have here. Then within CardContainer, you render each element in the props as a GrantCard or something. Essentially, CardContainer is just a reusable template component. It can even be reused on the proposals page and dashboard.

from udao.

austin-davis1 avatar austin-davis1 commented on August 30, 2024

That's a good idea, I will keep this in mind. This won't be an immediate priority for me, but once I get some free time from other issues I will definitely take a stab at this

from udao.

oslfmt avatar oslfmt commented on August 30, 2024

I see why you choose to implement it this way after looking more closely at the react code. I started work on this in a PR so you can take a look. The strategy I outlined above might have to be slightly modifier.

from udao.

oslfmt avatar oslfmt commented on August 30, 2024

Closing as new frontend fixes this

from udao.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.