Comments (5)
I think we might be able to close this issue now with the new frontend.
from udao.
I would've imagined something more like: the html code this Grants
component returns, returns another 2 child components, which are identical cards, maybe something like <CardContainer />
. Each of these components takes a props, which are the activeGrants
and inactiveGrants
you have here. Then within CardContainer
, you render each element in the props as a GrantCard
or something. Essentially, CardContainer
is just a reusable template component. It can even be reused on the proposals page and dashboard.
from udao.
That's a good idea, I will keep this in mind. This won't be an immediate priority for me, but once I get some free time from other issues I will definitely take a stab at this
from udao.
I see why you choose to implement it this way after looking more closely at the react code. I started work on this in a PR so you can take a look. The strategy I outlined above might have to be slightly modifier.
from udao.
Closing as new frontend fixes this
from udao.
Related Issues (20)
- Naming schemes for ERC721 vs ERC20 HOT 1
- Differentiate between proposals/grants from a technical standpoint HOT 1
- IPFS and Ethers connection organization issue HOT 1
- How to set contract abis, address, and provider HOT 1
- Delegate Voting Power HOT 2
- Reading financial data off the blockchain vs reading it off IPFS HOT 8
- Refresh Issue HOT 1
- Make the frontend look nice! HOT 1
- Error Handling in app HOT 2
- Timer display
- Fix metamask sign-in workflow HOT 2
- Confusing redirect after clicking on card and then clicking cancel
- Add create proposal functionality to new frontend HOT 1
- Enhancing the proposal submission redirection
- Card viewing problem with Redux HOT 1
- Labels on cards
- Adding actual content to the help page
- Dark and light mode
- Multiple languages
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from udao.