Comments (3)
Legend status once again @nickblt I can take this on. If I'm deciding, I kiind of like Stake
better (thinking more common reason would be to adjust liquidity mid-incentive without unnecessary transferring) but honestly it's a tough one, if anyone else has further thoughts feel free to comment
also you know better than I do @danrobinson. liquidity is in fact a legit truthiness value?? (as opposed to exists) it can never be 0??
from v3-staker.
@ewilz liquidity can be 0: https://etherscan.io/token/0xC36442b4a4522E871399CD717aBDD847Ab11FE88#readContract
from v3-staker.
Nice catch. I think adding uint128 liquidity
to the Deposit
struct, and using that in unstake
instead of reading the liquidity from the NFT, should fix this.
Alternatively, we could add it to the Stake
struct (which would give users a little more flexibility, plus let us drop the exists
flag), but that would add up to more than one storage slot.
from v3-staker.
Related Issues (20)
- consider time-vesting rewards by how long the position was in range HOT 1
- After endTime, the profit will still be calculated? why is that
- Add polygon deployment addresses in readme HOT 1
- How to get the IncentiveId after the creation ? HOT 1
- How to get Reward Info ? HOT 1
- Cannot find module '../../typechain'
- yarn test error on v1.0.2 tag HOT 1
- How to deploy to hardhat network
- No way to read all staked positions of a user address, in univ3 staker contract HOT 1
- invalid arrayify value when providing bytes argument to safeTransferFrom(address,address,uint256,bytes)
- Critical Security Issue
- Return
- - - [ ] #- [ ] #_@`~~~~`_
- Implement solidity 0.8 like v3-core and v3-periphery
- Withdraw remaining incentive token when incentive end HOT 1
- blockchains/binance/assets/AERGO-46B/logo.png
- blockchains/binance/assets/AERGO-46B/logo.png HOT 1
- github.com/trustwallet/asset
- Ace100
- Add Support for Base Network in v3-Staker
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from v3-staker.