Should liquidity be on Deposit or Stake? about v3-staker

[danrobinson]

@moodysalem why can't it just use the one from the Deposit?

[moodysalem]

it has to be cached per-stake, or else you don't know the liquidity the last time rewards were computed for a stake, no?

[omarish]

cc @danrobinson

[moodysalem]

the question is whether the user should have to withdraw token and then deposit token again or unstake and stake when the liquidity is increased on their nft

[danrobinson]

Yeah. I could be sold on it if we use the rest of the space in the Stake for something else (like reward token balance, which pairs nicely with it, as discussed out of band)

[moodysalem]

the ux is simpler if the user only has to unstake/stake the incentive they care about instead of unstake all/withdraw/deposit/stake all to update their liquidity, especially because unstake/stake can be done with a single multicall whereas withdraw/deposit requires calling both the staker and nft contract

withdrawToAndCall could allow for withdraw/deposit in a single tx from an eoa via an external contract

[moodysalem]

i think stake is the clear winner after the 1 slot most of the time stake update