claimRewards: specify an amount to claim about v3-staker

[moodysalem]

1. We could add a third param as uint256 claimAmount, but that would make things hard for people who want to claim everything, unless we also did item 2 in this list:

This is what we do with #collect, where the amount is a maximum to withdraw

To reduce calldata cost of specifying the max, you can treat 0 as the maximum (point 2 in your list, which is done just for calldata purposes)

You could do 3 and 2 and just call 2 from 3, to reduce calldata further (which is good for L2s)
but you can give them the same name, they will have a diff bytes4 function signature

[omarish]

Do we need this? I think it's a nice-to-have but let me know if you feel strongly and we can bump it. Are there use cases where someone would only want to partially claim rewards?

[moodysalem]

Do we need this? I think it's a nice-to-have but let me know if you feel strongly and we can bump it. Are there use cases where someone would only want to partially claim rewards?

mainly insolvency, for whatever reason the contract has less reward token than expected (e.g. the token collects a fee on transfer)

[omarish]

What's the best UX here?

Right the signature is: claimReward(IERC20Minimal rewardToken, address to).

Some ideas (just listing them out to be exhaustive):

1. We could add a third param as uint256 claimAmount, but that would make things hard for people who want to claim everything, unless we also did item 2 in this list:
2. We could make it such that if claimAmount is 0, then it claims rewards[rewardToken][msg.sender], but that feels a little bit messy.
3. We could add another function entirely partialClaimReward, but that seems superfluous.
4. We could make it claimReward(rewardToken, to, bool claimFullAmount, uint256 partialAmount)

Other ideas?

[omarish]

Ready for review: #166.