Coder Social home page Coder Social logo

Comments (5)

omarish avatar omarish commented on August 16, 2024

Hm interesting. If you think this is a common use case we could figure adding it in to the critical path. Gonna list it as a nice to have for now but let me know if you feel strongly otherwise.

from v3-staker.

moodysalem avatar moodysalem commented on August 16, 2024

it's def nice to have, not supported in any v2 liquidity mining atm

from v3-staker.

omarish avatar omarish commented on August 16, 2024

Nice to have or maybe not do, will decide

from v3-staker.

moodysalem avatar moodysalem commented on August 16, 2024

note this has to be a special callback, since using just the safeTransferFrom of the ERC721 is not sufficient because it does not say who owned the deposit

from v3-staker.

NoahZinsmeister avatar NoahZinsmeister commented on August 16, 2024

we could hack around the safeTransferFrom owner problem by pre-pending the deposit owner to the callback data and rely on implementers special-casing deposits from the staker

from v3-staker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.