Comments (4)
You should deploy and test against the bytecode in the artifacts directory, rather than compile it locally for testing. This issue sounds like an issue with the tooling you're using, not the code in the repo
from v3-periphery.
Actually, the contract is used by another one, so it needs to be imported, from where the problem arises - The entire contract gets recompiled, including the import, and the compilation fails.
from v3-periphery.
Actually, the contract is used by another one, so it needs to be imported, from where the problem arises - The entire contract gets recompiled, including the import, and the compilation fails.
That is the approach of the tool that is checking the code coverage, you should be able to exclude external dependencies from coverage testing (or if you are trying to coverage test this repo, then you will need to work around the technical limitations of the approach with that tool)
from v3-periphery.
Instead of having positions
return all 12 primitive types having it return a struct containing all 12 types could possibly fix your issue?
from v3-periphery.
Related Issues (20)
- ۲@hensha256 thank you. the error seems to be about a github integration failure. can you please retry/re-run the github action? HOT 2
- Do we have this already? HOT 1
- docs IUniversalRouter#execute x ISwapRouter#swapExactInputSingle x IUniswapV3PoolActions#swap
- Provide Clarity regarding base deployment addresses HOT 1
- Error invoking quoteExactInput HOT 1
- does uniswap v3 has deployed on bsc chain HOT 1
- I tried to call the quote contract method quoteExactInput on the arbitration goerli network, but it failed
- FullRange missing access controls (security bug) HOT 1
- uniswap v3 periphery npm package for compiler version 0.8.0 HOT 1
- contract size too big with compiler > 0.8.0
- On-chain staticcall IQuoter is not working HOT 1
- Cant find LiquidityAmounts in deployed contracts ABI
- Should upgrade @openzeppelin/contracts version in use HOT 2
- Feds sat and watch as team of coders perform malicious hacks.
- 1
- PositionValue may suffer from underflow in 0.8 version
- NonfungiblePositionManager.createAndInitializePoolIfNecessary throws EvmError: Revert
- Non-verified SwapRouter HOT 2
- uniswap
- Why lock WETH Interface at Solidity 0.8.15?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from v3-periphery.