warnings galore: conversion to '...' from '...' may alter its value about netcdf-c

[DennisHeimbigner]

We do not see these warning, which means
that we are not using the same compiler as you
or are not using the same -W flags.
We would like to fix/suppress these.
Can you tell me which compiler and flags you are using?
=Dennis Heimbigner
Unidata

Nico Schlömer wrote:

The number of build warnings on standard netcdf-c builds is overwhelming. On amd64, we're counting 2911 https://launchpadlibrarian.net/168739307/buildlog_ubuntu-trusty-amd64.netcdf_4.3.1.2~20140316-trusty1_UPLOADING.txt.gz, most of them of the type

conversion to '...' from '...' may alter its value

While all of them seem potentially dangerous, netcdf is the type of software that might actually want to allow this. Consequently, we would either

• fix the warnings, or
• adapt the build script to explicitly turn off the conversion warnings.

---

Reply to this email directly or view it on GitHub:
#33

[nschloe]

The link in the original post shows the make VERBOSE=1 output, so you'll find all flags in there. Specifically, the Ubuntu builds use -Wall -Wno-unused-variable -Wno-unused-parameter -Wconversion.

I also get those warnings on the most default builds on my Ubuntu 13.10 machine, as well as on travis-ci with Ubuntu 12.04, so I'm a little surprised that you guys don't see them.

[WardF]

I'm not a t my machine currently but there are cmake flags to toggle the conversion warnings. There is also a JIRA issue. I'll post the links when I get home.

[DennisHeimbigner]

Ward-
I am in the process of making a large number
of changes to address some of the conversion
issues (in oc2 anyway).
=Dennis

Ward Fisher wrote:

I'm not a t my machine currently but there are cmake flags to toggle the conversion warnings. There is also a JIRA issue. I'll post the links when I get home.

---

Reply to this email directly or view it on GitHub:
#33 (comment)

[WardF]

The original JIRA issue is here: https://bugtracking.unidata.ucar.edu/browse/NCF-266

Closing as duplicate.

[WardF]

Incidentally the CMAKE flags to enable these warnings are:

-DENABLE_CONVERSION_WARNINGS

It is ON by default. We haven't found any places where this is causing
an actual problem, but we have been slowly trying to address it
without causing any new issues.

-Ward

On 3/8/14, 11:21 AM, DennisHeimbigner wrote:

We do not see these warning, which means
that we are not using the same compiler as you
or are not using the same -W flags.
We would like to fix/suppress these.
Can you tell me which compiler and flags you are using?
=Dennis Heimbigner
Unidata

Nico Schlömer wrote:

The number of build warnings on standard netcdf-c builds is
overwhelming. On amd64, we're counting 2911
https://launchpadlibrarian.net/168739307/buildlog_ubuntu-trusty-amd64.netcdf_4.3.1.2~20140316-trusty1_UPLOADING.txt.gz,
most of them of the type

conversion to '...' from '...' may alter its value

While all of them seem potentially dangerous, netcdf is the type of
software that might actually want to allow this. Consequently, we
would either

• fix the warnings, or
• adapt the build script to explicitly turn off the conversion warnings.

---

Reply to this email directly or view it on GitHub:
#33

—
Reply to this email directly or view it on GitHub
#33 (comment).