List of remote tests wrong about netcdf-c

[DennisHeimbigner]

partvar2 is intentionally disabled.
If you examine ncdap_test/Makefile.am
(from which CMakefiles.txt is taken),
you will see that test_partvar.c is included,
but test_partvar2.c is not. This is intentional.
=Dennis Heimbigner
Unidata

Nico Schlömer wrote:

The file https://github.com/Unidata/netcdf-c/blob/master/ncdap_test/CMakeLists.txt lists a number of DAP remote tests, but that list is at least incomplete. test_partvar fails for me with

$ grep findtestser * -r
[...]
ncdap_test/test_partvar2.c:    svc = NC_findtestserver("dts");
ncdap_test/test_partvar.c:    svc = NC_findtestserver("dts");
ncdap_test/test_varm3.c:        const char* svc = NC_findtestserver("thredds");
ncdap_test/nctestserver.c:    url = NC_findtestserver(argv[1]);

In fact, the only test that does fail if I turn off network connectivity is ncdap_test_partvar.

---

Reply to this email directly or view it on GitHub:
#31

[nschloe]

This intention of the report is to point out that there are tests which contain NC_findtestserver, but are not listed as ENABLE_DAP_REMOTE_TESTS. This is true for all of the above files.

[DennisHeimbigner]

I see. Ok.
I missed including these in
ENABLE_DAP_REMOTE_TESTS.
Thanks for the heads up.
=Dennis Heimbigner
Unidata

Nico Schlömer wrote:

This intention of the report is to point out that there are tests which contain NC_findtestserver, but are not listed as ENABLE_DAP_REMOTE_TESTS. This is true for all of the above files.

---

Reply to this email directly or view it on GitHub:
#31 (comment)

[nschloe]

As per commit a189b98.