Fix HDF4 support, broken since release 4.3.1.1 about netcdf-c

[WardF]

Weird; I'll take a look at this. I've been meaning to integrate hdf4 into the nightly and continuous testing, this seems like a good time to.

[WardF]

Using git bisect I was able to narrow down the error to commit b2dfacbcfab41b539f555f033b32393f9af59252. I'll take a closer look in a bit to see if I can narrow down the issue.

[russrew]

Thanks, I fixed the compile errors resulting from change of a field name in att and var->typeinfo structs, from xtype to nc_typeid. However, now there's a runtime error due to a problem in reference counts for the typeids, for builds with --enable-hdf4-file-tests, so I'm not closing issue yet.

[qkoziol]

On Feb 23, 2014, at 12:37 PM, Russ Rew [email protected] wrote:

Thanks, I fixed the compile errors resulting from change of a field name in att and var->typeinfo structs, from xtype to nc_typeid. However, now there's a runtime error due to a problem in reference counts for the typeids, for builds with --enable-hdf4-file-tests, so I'm not closing issue yet.

Drat!  Sorry about that, would you like me to look into the current situation?  (I'll also add an HDF4 build to my testing regime before checking things in, as soon as this is fixed)

Quincey

[russrew]

It would be great if you could fix the current assertion failures with reference counts, both occurring in nc4internal.c:

Assertion failed: (type->rc), function nc4_type_free, file ../../libsrc4/nc4internal.c, line 902.

Probably just a missing type->rc++ somewhere ...

[WardF]

Hey Quincey, since it sounds like you're familiar with the code in question, it would probably be faster if you look into it instead of me. I'll add hdf4 tests to the continuous testing for your development branch as well as our own.

[qkoziol]

OK, I'll try to get to it today (although I'm home with a sick child, so it might be tomorrow).

Quincey

On Feb 24, 2014, at 9:59 AM, Ward Fisher [email protected] wrote:

Hey Quincey, since it sounds like you're familiar with the code in question, it would probably be faster if you look into it instead of me. I'll add hdf4 tests to the continuous testing for your development branch as well as our own.

—
Reply to this email directly or view it on GitHub.

[qkoziol]

Working on this now...

Quincey

On Feb 24, 2014, at 9:59 AM, Ward Fisher [email protected] wrote:

Hey Quincey, since it sounds like you're familiar with the code in question, it would probably be faster if you look into it instead of me. I'll add hdf4 tests to the continuous testing for your development branch as well as our own.

—
Reply to this email directly or view it on GitHub.

[qkoziol]

OK, that wasn't too difficult - I've submitted a pull request for the change.

Quincey

On Feb 24, 2014, at 9:59 AM, Ward Fisher [email protected] wrote:

Hey Quincey, since it sounds like you're familiar with the code in question, it would probably be faster if you look into it instead of me. I'll add hdf4 tests to the continuous testing for your development branch as well as our own.

—
Reply to this email directly or view it on GitHub.

[russrew]

Fixed, so I'm closing it.

[zxdawn]

@qkoziol Hi Quincey, I meet the same error when I'm using WRF model:

wrf.exe: nc4internal.c:902: nc4_type_free: Assertion `type->rc' failed.

However, this happened after two day's running, not happened at first.

compiler: intel 15.0.1
netcdf: 4.3.3.1
pnetcdf: 1.6.1
MPICH:3.1

[edhartnett]

Can you upgrade netcdf? Hdf4 works great in recent 4.6.2 release, for example.

[zxdawn]

Can you upgrade netcdf? Hdf4 works great in recent 4.6.2 release, for example.

@edhartnett Thank you for your suggestion. But, netcdf 4.3.3.1 works fine for generating hundred files. This issue happened at one moment after that. If it's the problem of version, why not happen at first?

[zxdawn]

The complete description is on the WRF forum. I'm not sure it's related to netcdf or tasks.