Value of UC_MODE_BIG_ENDIAN about unicorn

[aquynh]

not really. please take another unused number for that, thanks.

[cseagle]

I have requested to change this to 1<<30 in my java related pull

[radare]

Is there a reason to use a signed type for a bitmask field?

On 29 Aug 2015, at 04:33, Chris Eagle [email protected] wrote:

Is there a compelling reason for this to be 1<<31 (ie 2147483648)? This is larger than INT_MAX and cause javac to complain.

—
Reply to this email directly or view it on GitHub.

[cseagle]

java doesn't have unsigned integers

[radare]

Then use long with a bitmask, there would be enough bits to fit them all.

But that case was clearly fine for simplicity because there are not enough modes to justify the use of a bigger type.

👍

On 29 Aug 2015, at 08:28, Chris Eagle [email protected] wrote:

java doesn't have unsigned integers

—
Reply to this email directly or view it on GitHub.

[cseagle]

Because of the const_generator, that would require declaring every constant in unicorn as a long which seems extraordinarily wasteful given the small values used across all of the constants.