Coder Social home page Coder Social logo

Comments (6)

canadaduane avatar canadaduane commented on June 14, 2024 2

Bingo! Demo is working. Thank you.

FYI: there are more Typescript/ESLint warnings, but none were blockers (e.g. "defined but never used").

from threejs-lightmap-baker.

unframework avatar unframework commented on June 14, 2024

Hey, thanks for checking out the repo!

I just added a type declaration for *.glb files, maybe that will fix the error above. Not sure what to say about the useIrradianceRenderer error - I did a fresh check-out here and yarn start seems to work. If it still happens on latest master, mind reporting that trace as well?

And I need to add a screenshot in README, hehe. Here is a short overview post with pictures: https://unframework.com/portfolio/simple-global-illumination-lightmap-baker-for-threejs/.

from threejs-lightmap-baker.

canadaduane avatar canadaduane commented on June 14, 2024

Looks like that fixed the glb file issue!

Here is what I'm seeing after that:

Failed to compile.

/Users/duane/tmp/threejs-lightmap-baker/src/IrradianceKeyframeRenderer.tsx
TypeScript error in /Users/duane/tmp/threejs-lightmap-baker/src/IrradianceKeyframeRenderer.tsx(4,10):
Module '"../../../../../Users/duane/tmp/threejs-lightmap-baker/src/IrradianceRenderer"' has no exported member 'useIrradianceRenderer'. Did you mean to use 'import useIrradianceRenderer from "../../../../../Users/duane/tmp/threejs-lightmap-baker/src/IrradianceRenderer"' instead?  TS2614

    2 | import * as THREE from 'three';
    3 |
  > 4 | import { useIrradianceRenderer } from './IrradianceRenderer';
      |          ^
    5 |
    6 | export function useIrradianceKeyframeRenderer(
    7 |   factorName: string,

When I look at IrradianceRenderer.tsx, I don't see useIrradianceRenderer being declared or exported anywhere (maybe it's supposed to be autogenerated?)

from threejs-lightmap-baker.

unframework avatar unframework commented on June 14, 2024

Good catch, that IrradianceKeyframeRenderer.tsx file is not even used anymore. I updated the code accordingly.

It is quite odd that my create-react-app does not complain about TypeScript errors - must be something on my end then.

from threejs-lightmap-baker.

canadaduane avatar canadaduane commented on June 14, 2024

More progress! :)

Now I see this:

Failed to compile.

/Users/duane/tmp/threejs-lightmap-baker/src/App.tsx
TypeScript error in /Users/duane/tmp/threejs-lightmap-baker/src/App.tsx(15,47):
Cannot find module './IrradianceKeyframeRenderer'.  TS2307

    13 | import IrradianceRenderer from './IrradianceRenderer';
    14 | import { PROBE_BATCH_COUNT } from './IrradianceLightProbe';
  > 15 | import { useIrradianceKeyframeRenderer } from './IrradianceKeyframeRenderer';
       |                                               ^
    16 | import IrradianceCompositor from './IrradianceCompositor';
    17 | import SceneControls from './SceneControls';
    18 | import GridGeometry from './GridGeometry';

from threejs-lightmap-baker.

unframework avatar unframework commented on June 14, 2024

Ok, I removed that one as well. Hopefully it works!

from threejs-lightmap-baker.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.