newest version yields all sorts of incorrect results... about grunt-uncss

[addyosmani]

Thanks for the bug report. Would it be possible to share a minimal test case reproducing the issue? Alternatively a summary of whether there are complex selectors in your stylesheet would help us nail down the issue.

cc @giakki in case this happens upstream too.

[giakki]

It is not happening upstream, actually. I added a specific tests for :hover, and it passes without problems, and so does the example page from grunt-uncss.
IIRC, the method for parsing unused selectors hasn't changed between the two versions, could you share an example of it happening, so I can look into it?
Thanks!

[ukeboyska]

here's a stripped down version of my environment: https://www.dropbox.com/s/aq2utuvymc5dwxm/uncss-test.zip

to reiterate, i tested it before the latest pull and it seemed to be working fine except for html files that were too big (that bug was fixed) and the stylesheets option (that seems to have also been fixed). however, now the uncss stylesheet is half the size of what it was previously, and it's missing important styles.

note: the changes i made to my stylesheet in between tests is negligible. simple style updates here and there - nothing that would affect overall style structure, etc.

[giakki]

Thanks, I'll try and check what's wrong ASAP!

[addyosmani]

Could you try out 0.1.9 and let me know if this is still an issue?

@giakki were you able to find out if this is an issue upstream?

[ukeboyska]

@addyosmani updating to the newest version there are 3 main changes:

1. the uncss task is noticably longer. on my project it clocked in at a whopping 2 minutes. i don't remember it ever taking more than 20 seconds before this last update...
2. my screen.un.css is now at its expected size again -- 72kb again, which is good!
3. pretty much all the CSS works perfectly except for hovers in my navigation unless i put in some special ignore options. for example, class="hoverable" is in the HTML file, but none of the .hoverable declerations get included in the un.css file unless i put "ignore: [/hoverable/," in the options. note: i did not have to "hack" it to fix it in earlier versions.

overall: definitely happier, but something still seems a little fishy! also the whole 2 minute task thing dissuades me from integrating this into general workflow...

thanks guys!

[giakki]

Sorry for the delay, I'm happy you managed to get it working at least!
I'll look into the two issues that you mentioned, especially the performance one looks strange.
Thanks again!

[addyosmani]

I believe @giakki attempted to address some of the regressions introducing performance issues back in 35 (upstream). This shouldn't be as slow now.