Coder Social home page Coder Social logo

Comments (4)

ricardorei avatar ricardorei commented on June 16, 2024

Hey @nkw011! The build_activation function seems to be lacking some flexibility.

I think the best thing to do is to just modify it to be the following:

def build_activation(self, activation: str) -> nn.Module:
    if hasattr(nn, activation):
        return getattr(nn, activation)()
    else:
        raise Exception(f"{activation} is not a valid activation function!")

and then everything should work.

from comet.

ricardorei avatar ricardorei commented on June 16, 2024

the reason its not working atm is that when you pass "ReLU" it will be converted to the string "Relu" by the title function and thus it will not match any of the activation functions in the torch.nn package

from comet.

nkw011 avatar nkw011 commented on June 16, 2024

@ricardorei Thank you for replying my question! I'm sorry but have one more question. The build activation function is located in comet/modules/feedforward.py. Can I get a way to modify the bulid activation function in pip package 'unbabel-comet' installed in local computer as you explain?

from comet.

ricardorei avatar ricardorei commented on June 16, 2024

You should be able to do it. When you installed the package the code was stored somewhere in your computer. You just have to locate the source code and modify the function.

A simpler alternative is to just install the code from source:

Just clone the repo to your favourite location and install it:

git clone https://github.com/Unbabel/COMET
cd COMET
pip install poetry
poetry install

Then you can modify whatever you like.

from comet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.