Update Avatar storage and image url generation about inbox

[skushagra9]

Can I work on this ?

[cstrnt]

between

Agree! We could prefix the nanoId with the type so it ends up like _. Unkey is doing that (as well as stripe) and I love that

[McPizza0]

prefix the nanoId with the type so it ends up like _.

good idea, updated issue description
we good to go @cstrnt ?

[cstrnt]

Looks good to me. Should be scoped well enough for implementation

[cstrnt]

I would honestly just add a field to each model in the db schema like avatarUrl which can be nullable.
This allows us to not fetch the avatar if there isn't one or just default to some other URL :)

Also makes caching less of an issue since we aren't just re-using the same URL but rather generate a new URL for the avatar. Therefore we can just mark the old avatar as immutable and cache it on the CDN and browser forever

[skushagra9]

@cstrnt are you working on this ??

[cstrnt]

@skushagra9 nope, I think we should still discuss a little about the implementation and its implications before we do that. Feel free to leave your thoughts here

[McPizza0]

I would honestly just add a field to each model in the db schema like avatarUrl which can be nullable.
This is how we had it when using cloudflare images
switched to current method to ensure that unused (replaced) avatars dont take up unnecessary storage space

we could achieve the same as your proposal by having avatar = true in the db instead of a url
and pass that to the avatar component

though this dosnt solve the caching issue

[cstrnt]

That's right, both solutions have advantages and disadvantages. I personally lean towards the solution of storing the url in the db (reference: dub)

[McPizza0]

thought about this some more
i agree with your approach @cstrnt but we should store an avatarId (not full url) in the tables.
the url would end up being the storage app url which may change over time (CDN, regions, AGI etc)

we can generate this avatarId using nanoIdLong from utils package (32 char length alphanumeric id)

Q: when uploading to s3, current path format is /avatars/${type}/${profile.publicId} - do we keep type as a separation between avatar types, or merge all into one path?

[McPizza0]

updated issue description