Coder Social home page Coder Social logo

Comments (7)

danpoland avatar danpoland commented on June 8, 2024

Any chance this is being worked on? This issue makes using the lib for anything but really simple models almost impossible.

from django-rest-framework-mongoengine.

umutbozkurt avatar umutbozkurt commented on June 8, 2024

I'll look into it as soon as I got spare time

from django-rest-framework-mongoengine.

danpoland avatar danpoland commented on June 8, 2024

Thanks, I will do the same.

from django-rest-framework-mongoengine.

danpoland avatar danpoland commented on June 8, 2024

The readme says: "Depth is optional and defaults to 5. It is used for ReferenceField & ListField."

The fix to get to this state is pretty simple. However, I would not expect depth to determine how deep the serializer goes into a ListField. Only how many relationships the serializer follows.

From the Django REST framework documentation: "The depth option should be set to an integer value that indicates the depth of relationships that should be traversed before reverting to a flat representation."

from django-rest-framework-mongoengine.

umutbozkurt avatar umutbozkurt commented on June 8, 2024

You've got a point. Depth should not be used in ListField directly.
Fixing depth argument should fix @crhuber 's specific issue on #37

from django-rest-framework-mongoengine.

umutbozkurt avatar umutbozkurt commented on June 8, 2024

I will take a look at this this tonight

from django-rest-framework-mongoengine.

danpoland avatar danpoland commented on June 8, 2024

I forked your repo and wrote a solution. If you are interested in what I did checkout danpoland@80db2df.

I put a pull request in.

from django-rest-framework-mongoengine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.