Comments (5)
Just tested and it works fine for me. What browser are you using?
from website.
In Safari (desktop), the pricing link in header does not load the pricing info.
The version I have is 16.2 (16614.3.7.1.7, 16614) on Mac OS Big Sur 11.7.1 (20G918).
It works fine in Chrome and Firefox.
Sorry about that. I should have mentioned the browser and platform.
from website.
I have more details. In Safari, when bookmarks sidebar is open, then Pricing link only highlights blue in the upper left portion of the text. Then the rest of the text is "unclickable." I admit it's a bit obscure of a bug.
If the issue isn't closed, I'd like to try my hand at a hack for it, a proper fix notwithstanding--or if a PR comes in for it, at any rate.
from website.
The <a>
anchor tag is not triggering by itself; it's based on its <div>
parent.
When Safari sidebar is closed, the parent's "hitbox" envelops the entire menu items, so there's no issue.
When Safari sidebar is open, since the hitbox is centered, the "Fe" portion of "Features" text is excluded (but still highlights starting from the beginning).
On the right side of the menu, the text "Pric" (and some of the "i") in Pricing is included and "ng" is excluded. Link highlighting only happens once we move more to the left.
I can repro the issue by the following steps:
- Adding these lines to pages/index.tsx:
import React from 'react';
import { NextPage } from 'next';
+import Inline from 'components/Inline';
...
+ <Inline />
</>
);
};
- And in the new file components/Inline.tsx,
import Script from 'next/script'
export default function Inline() {
return (
<>
<Script id="diagnosis">
{`
let pricingElement = document.querySelector('header a:nth-child(4)'),
menu = pricingElement.parentElement
// destroys responsive mode
// menu.style.flex = "0 0 100%"
pricingElement.addEventListener("mouseenter", (e) => { pricingElement.style.border = '5px dotted orange' })
pricingElement.addEventListener("mouseleave", (e) => { pricingElement.style.border = '' })
}`
</Script>
</>
)
}
The Pricing link highlights as expected when flex
is changed from auto
to 100%
, but that destroys responsive mode and takes up the rest of the row, dropping the GitHub icon to the next line. So we can't have that.
That's what I've found so far. Here is a gif:
from website.
Figured it out :) Sent up a PR #109. Thank-you.
from website.
Related Issues (20)
- Dark Mode HOT 2
- Syntax Highlighting in docs HOT 1
- /api/send:1:0(analytics.umami.is) Failed to load resource: the server responded with a status of 401 (Unauthorized) HOT 1
- v1 docs availability HOT 1
- Docs navigation issues HOT 3
- Getting started button on homepage should go to docs HOT 6
- Can't view stats of my website
- Uninformative page titles HOT 5
- Some API doc/sample seems not up-to-date
- Custom Cursor
- Copy Code Feature in the Documentation
- Internationalization
- Update the Quotes section
- Wrong link on Umami Plugin for Docusaurus HOT 1
- Umami docs pages are broken HOT 3
- Confusing "Last..." naming HOT 4
- Overflow on Mobile devices on docs page.
- Redicrect to Not Found page.
- Website https://umami.is down HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from website.