Coder Social home page Coder Social logo

Comments (12)

altonen avatar altonen commented on May 26, 2024

Hi,

yes it would be nicer but I personally don't see it as a huge issue that they are all in the same directory. If you want this to be changed, please open a pull request.

from uvgrtp.

db-tech avatar db-tech commented on May 26, 2024

If you consider accepting this style, I will create a PR

from uvgrtp.

jrsnen avatar jrsnen commented on May 26, 2024

I would also consider this an improvement. Thank you for the suggestion.

from uvgrtp.

jrsnen avatar jrsnen commented on May 26, 2024

What is the situation on the PR? I could attempt to do this. It seems there are some header dependencies that would probably need to be eliminated.

from uvgrtp.

db-tech avatar db-tech commented on May 26, 2024

Wanted to start with that next week. But if you have the time, be my guest :-)
Then I would do issue #13.
That kind of depends on this one.
If you start with it and need some input or help, let me know.

from uvgrtp.

jrsnen avatar jrsnen commented on May 26, 2024

I'm sorry, but this proved to be too big of a task for me at this point. I managed to reduce header dependencies, but there is no clear API defined in uvgRTP, which makes it hard to determine which headers are necessary and which are not. In addition, I was not able to remove all the dependencies (in rtcp.hh) which makes it difficult to eliminate those headers. I'll update my changes so far this week.

@altonen Do you have a list of which headers are necessary to use the library and which are meant to be internal headers? For example, I sow the need to free the frame using function from frame.hh which I thought was internal.

from uvgrtp.

jrsnen avatar jrsnen commented on May 26, 2024

I updated the repo with reduced header dependencies.

lib.hh now includes all the header files since I didn't know which ones were required. This is basically the same as before because of the header dependencies.

from uvgrtp.

jrsnen avatar jrsnen commented on May 26, 2024

After a discussion with @altonen, we settled on a list of headers that are needed in the include folder. There are few extra because of rtcp.hh, but in general decde85 is a big improvement on this matter. Feel free to improve it further if you have ideas.

from uvgrtp.

db-tech avatar db-tech commented on May 26, 2024

Awesome, i will take a Look tomorrow.

from uvgrtp.

db-tech avatar db-tech commented on May 26, 2024

I did a minimalistic check of the commit. I would need more time to check if we could do more Improvements. Unfortunately, I am not able to be more thorough at the moment.

I still have some comments:

  1. I would consider creating a subdirectory uvgrtp in the include directory. That would be nicer in the internal include statements and easy to distinguish between private and public header.
  2. I would try to avoid relative include paths like this "../xyz.hh" but rather adding the src dir to the private include paths in cmake.

from uvgrtp.

jrsnen avatar jrsnen commented on May 26, 2024

I create a separate issue for your comment 2. Comment 1 should be implemented and is related to this issue.

from uvgrtp.

jrsnen avatar jrsnen commented on May 26, 2024

Merged with #44

from uvgrtp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.