Comments (12)
Hi,
yes it would be nicer but I personally don't see it as a huge issue that they are all in the same directory. If you want this to be changed, please open a pull request.
from uvgrtp.
If you consider accepting this style, I will create a PR
from uvgrtp.
I would also consider this an improvement. Thank you for the suggestion.
from uvgrtp.
What is the situation on the PR? I could attempt to do this. It seems there are some header dependencies that would probably need to be eliminated.
from uvgrtp.
Wanted to start with that next week. But if you have the time, be my guest :-)
Then I would do issue #13.
That kind of depends on this one.
If you start with it and need some input or help, let me know.
from uvgrtp.
I'm sorry, but this proved to be too big of a task for me at this point. I managed to reduce header dependencies, but there is no clear API defined in uvgRTP, which makes it hard to determine which headers are necessary and which are not. In addition, I was not able to remove all the dependencies (in rtcp.hh) which makes it difficult to eliminate those headers. I'll update my changes so far this week.
@altonen Do you have a list of which headers are necessary to use the library and which are meant to be internal headers? For example, I sow the need to free the frame using function from frame.hh which I thought was internal.
from uvgrtp.
I updated the repo with reduced header dependencies.
lib.hh now includes all the header files since I didn't know which ones were required. This is basically the same as before because of the header dependencies.
from uvgrtp.
After a discussion with @altonen, we settled on a list of headers that are needed in the include folder. There are few extra because of rtcp.hh, but in general decde85 is a big improvement on this matter. Feel free to improve it further if you have ideas.
from uvgrtp.
Awesome, i will take a Look tomorrow.
from uvgrtp.
I did a minimalistic check of the commit. I would need more time to check if we could do more Improvements. Unfortunately, I am not able to be more thorough at the moment.
I still have some comments:
- I would consider creating a subdirectory uvgrtp in the include directory. That would be nicer in the internal include statements and easy to distinguish between private and public header.
- I would try to avoid relative include paths like this "../xyz.hh" but rather adding the src dir to the private include paths in cmake.
from uvgrtp.
I create a separate issue for your comment 2. Comment 1 should be implemented and is related to this issue.
from uvgrtp.
Merged with #44
from uvgrtp.
Related Issues (20)
- Multiplexing packets based on protocol HOT 3
- Streaming 4K H264 video through Wireguard VPN HOT 9
- Compilation on Nanopi board HOT 3
- RTCP interval issues HOT 2
- A mistake for APP packet payload copying HOT 1
- Python API HOT 1
- Failed to flush the message queue HOT 15
- RTP header extension HOT 2
- uint8 overflow in a test HOT 2
- H264 Failed to flush the message queue HOT 16
- H265 Failed to flush the message queue HOT 3
- Streaming H264 video HOT 2
- Visual Studio Library Linking Documentation HOT 2
- Not Receiving RTP Packets from FFmpeg HOT 5
- H26x: Aggregation causes NAL units to be sent in different order HOT 5
- H26x incorrectly detected start code if preceded by 0x1 HOT 1
- H26x 00 01 00 detected as start code at certain alignments HOT 3
- bug in reception_flow.cc HOT 3
- error in uvgrtp::formats::h26x::packet_handler HOT 2
- [Android] Library fails to compile (at least for old SDK level 21) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uvgrtp.