Coder Social home page Coder Social logo

Comments (10)

hoijui avatar hoijui commented on May 23, 2024 1

As an alternative, you might want to have a look at the very powerful KiBot tool.

from uhk60v1-electronics.

mondalaci avatar mondalaci commented on May 23, 2024

Awesome thought of automating this!

Just made you a collaborator of this repo with write access, and assigned this issue to you.
Please let's not change the board files until the visual diff mechanism is in place. I'm very afraid of the board changes as I can't see them and they may result in broken boards which translate to huge problems / losses upon manufacturing the PCB.

Sorry for the delay regarding the other issues, I'll catch up later on.

Thank you so much!

from uhk60v1-electronics.

spuder avatar spuder commented on May 23, 2024

Awesome thanks.
I understand that you have plenty of other things to worry about right now.
I have some manual diffs ready now, but I'm ok waiting to merge them until we have a more polished diff system in place.

from uhk60v1-electronics.

spuder avatar spuder commented on May 23, 2024

I have a working implementation in this branch in my fork

https://github.com/spuder/electronics/tree/feature/wip_travis

It still has the following issues:

  • Granting public access to the s3
  • Minor updates to the diffs
  • Decide if travis should generate gerbers too

from uhk60v1-electronics.

spuder avatar spuder commented on May 23, 2024

Stand by, i'll be pushing a script soon that uses vagrant and the kicad python api to make images showing diffs. Its as native as can be right now

from uhk60v1-electronics.

spuder avatar spuder commented on May 23, 2024

I have opened merge request #27 It has a fairly polished collection of scripts that when run generate 14 pdf files, converts them to .png files, and then runs compare to show the changes

./scripts/generate-png-diff.sh

The script that generates the plots is located externally here:

https://gist.github.com/spuder/4a76e42f058ef7b467d9

It still could use some minor improvements, but it is good enough to see at a glance exactly what was changed.

It also has a travis config file, that runs these scripts.

Here is what happens if nothing has changed:

https://travis-ci.org/spuder/electronics/builds/98057604

Here is what it looks like when a change is made to a file ending in .kicad_pcb

https://travis-ci.org/spuder/electronics/builds/97929762

There are still two remaining tasks

  • Automatically upload the .png artifacts to amazon s3 or imgur.com on commit
  • Have travis-ci post a link to the generated files inside the comments section of github.

I'll keep working on those, but I want to merge what I have now so that people can use these scripts without waiting.

Here are some samples of what happens when the kicad_file is edited. Here I intentionally moved the rj11 connector:

left-main-layout-1

left-main-assytop-1

from uhk60v1-electronics.

mondalaci avatar mondalaci commented on May 23, 2024

I'm absolutely thrilled about this, thank you so much @spuder! Let me merge the relevant pull request real quick.

from uhk60v1-electronics.

mondalaci avatar mondalaci commented on May 23, 2024

@timofonic Sure thing, everybody's welcome to hack the schematic! Let me know if you need any help.

from uhk60v1-electronics.

spuder avatar spuder commented on May 23, 2024

Marking as done.
Having travis upload the .png files to imgur and automatically posting links in the github comments wont have much use, since travis secrets are not persisted across forks. I won't automate that unless I there is a real need, and I figure out a way that works with forks.

I'll update the README instructing users to upload their diffs manually.

from uhk60v1-electronics.

mondalaci avatar mondalaci commented on May 23, 2024

@spuder Thank you for your hard work, this looks excellent the way it is! The rest is only icing on the cake and certainly not urgent.

from uhk60v1-electronics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.