Support for long about hashids.net

[ullmark]

Hi, not at this point but should be possible to add. I will have a look.

On 21 nov 2014, at 11:33, nripendra [email protected] wrote:

Hi,

I was trying to generate hashid for long data type but it doesn't seem to have support?

—
Reply to this email directly or view it on GitHub.

[cdebry]

+1

[ullmark]

This is a bit tricky, I would either have to always return a long from the Decode function or provide a
DecodeInt64 to not make a breaking change, I say that the latter is needed.

[nripendra]

Yes, I think it will be important to have backward compatibility. You can also create new class if you think that will be cleaner.

[ullmark]

started implementing in https://github.com/ullmark/hashids.net/tree/long-support will close this issue when done.

[RodH257]

@ullmark this is awesome! I was coming here to see if there was any plans for long support and it's already underway. Let me know if there's anything I can do to help finalising it

[ullmark]

Hi guys, I just want to update the status.
I have updated the code to support long, and most of the tests are green, however I when randomly added VERY large numbers and trying them back and forth I get a red test. Trying to track down the culprit.

@RodH257 You are very welcome to help out, I'll shoot you a note when I've pushed everything I have locally for the long-support.

[bchavez]

👍 for long support.

[ullmark]

I have pushed my work in progress for the long support to my feature branch, some bug fixing to do, but we have the new functions EncodeLong and DecodeLong.

I also added an interface and some other bits.

[ullmark]

found the issue where I threw away some data. The long support is good to go, will send out a new package on nuget during the day.

[ullmark]

Pushed to nuget with version 1.1.0