Coder Social home page Coder Social logo

Comments (9)

jaywcjlove avatar jaywcjlove commented on July 21, 2024 1

@MatthewHerbst https://codesandbox.io/embed/react-textarea-code-editor-for-example-github-com-uiwjs-react-textarea-code-editor-issues-134-ex2v6j?fontsize=14&hidenavigation=1&theme=dark

This is an example, you need to improve

import { useEffect, useState } from "react";

export function useTheme() {
  const mode = getComputedStyle(document.documentElement).getPropertyValue(
    "content"
  );
  const [theme, setTheme] = useState(mode === '"dark"' ? "dark" : "light");
  useEffect(() => {
    window.matchMedia("(prefers-color-scheme: light)").onchange = (event) => {
      if (event.matches) {
        setTheme("light");
      }
    };
    window.matchMedia("(prefers-color-scheme: dark)").onchange = (event) => {
      if (event.matches) {
        setTheme("dark");
      }
    };
  }, []);
  return { theme, setTheme };
}
import React from "react";
import ReactDOM from "react-dom";
import CodeEditor from "@uiw/react-textarea-code-editor";
import "./index.css";
import { useTheme } from "./useTheme";

function App() {
  const { theme } = useTheme();
  const [code, setCode] = React.useState(
    `function add(a, b) {\n  return a + b;\n}`
  );
  console.log("theme:", theme);
  return (
    <div data-color-mode={theme}>
      <h3>Auto</h3>
      <CodeEditor
        value={code}
        language="js"
        placeholder="Please enter JS code."
        onChange={(evn) => setCode(evn.target.value)}
        padding={15}
        style={{
          fontFamily:
            "ui-monospace,SFMono-Regular,SF Mono,Consolas,Liberation Mono,Menlo,monospace",
          fontSize: 12
        }}
      />
    </div>
  );
}
/* Light mode */
@media (prefers-color-scheme: light) {
  html {
    content: "light"; /* (ab)using the content property */
  }
}

/* Dark mode */
@media (prefers-color-scheme: dark), print {
  html {
    content: "dark"; /* (ab)using the content property */
  }
}

from react-textarea-code-editor.

jaywcjlove avatar jaywcjlove commented on July 21, 2024

@MatthewHerbst https://stackoverflow.com/a/59223868/1334703

Since Chrome version 79 you can toggle between prefers-color-scheme: dark and prefers-color-scheme: light from the Rendering panel

  1. Open Developer tools (otherwise the key combination below opens the print dialog)
  2. Open the Command Control: Ctrl+Shift+P or Command+Shift+P (Mac)
  3. Type "Show rendering"
  4. Set the Emulate CSS media feature prefers-color-scheme to the value you want to debug

drop down to select the mode

from react-textarea-code-editor.

MatthewHerbst avatar MatthewHerbst commented on July 21, 2024

Hi @jaywcjlove I know that I can do that as a developer, but that solution isn't sufficient for an end-user of a website

from react-textarea-code-editor.

MatthewHerbst avatar MatthewHerbst commented on July 21, 2024

https://codesandbox.io/embed/react-textarea-code-editor-for-example-github-com-uiwjs-react-textarea-code-editor-issues-134-ex2v6j?fontsize=14&hidenavigation=1&theme=dark

While this is at least an improvement since now all the text is legible, this still prints the light version instead of the dark version.

Screenshot 2023-01-02 at 10 13 29 PM

react-textarea-code-editor should ensure the styles when printing are the same as the styles when not printing.

from react-textarea-code-editor.

jaywcjlove avatar jaywcjlove commented on July 21, 2024

The print style is given by the Chrome browser. It needs to be set manually.
@MatthewHerbst

from react-textarea-code-editor.

MatthewHerbst avatar MatthewHerbst commented on July 21, 2024

It needs to be set manually

I can't tell the end user who isn't a programmer how to set it. react-textarea-code-editor needs to "Just Work". It is possible to set the print style:

@media print {
 /** Set print-only styles here */
}

from react-textarea-code-editor.

jaywcjlove avatar jaywcjlove commented on July 21, 2024

Although the printing theme is set, the browser theme is still light, which needs to be set manually. @MatthewHerbst

@media print {
 /** Set print-only styles here */
  html {
    content: "dark"; /* (ab)using the content property */
  }
}

from react-textarea-code-editor.

MatthewHerbst avatar MatthewHerbst commented on July 21, 2024

Then please make the changes in

https://codesandbox.io/embed/react-textarea-code-editor-for-example-github-com-uiwjs-react-textarea-code-editor-issues-134-ex2v6j?fontsize=14&hidenavigation=1&theme=dark

be part of the code, that way it "works" even without being set. And please add instructions about this to the README so your users know what to do.

from react-textarea-code-editor.

jaywcjlove avatar jaywcjlove commented on July 21, 2024

@MatthewHerbst I tried integrating the system light and dark themes, but it will be missing some features. E.g:

+ <div data-color-mode="light">
  <h3>Light</h3>
  <CodeEditor
    value={code}
    ref={textRef}
    language="js"
    placeholder="Please enter JS code."
    onChange={(evn) => setCode(evn.target.value)}
    padding={15}
    style={{
      fontFamily:
        "ui-monospace,SFMono-Regular,SF Mono,Consolas,Liberation Mono,Menlo,monospace",
      fontSize: 12
    }}
  />
+ </div>

from react-textarea-code-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.