webpack: Failed to compile. (in a pure repo clone) about sample-app-angular

[christopherthielen]

Bad things happen when npm installs two copies of @uirouter/core. (note: yarn handles this with no problems). There was an explicit dependency on @uirouter/core@^5.0.0 and a transitive dependency through @uirouter/angular. npm seems to install one copy for each dependency.

I removed the explicit dependency on @uirouter/core in package.json and npm is now only installing one copy.

[nacmacfeegle]

Seeing this too

$ npm -v
3.10.8

$ node -v
v6.9.0

$ tsc -v
Version 2.3.2

[muscleman]

I cast routerFunc as and it compiled

[muscleman]

I cast routerFunc as ANY and it compiled

[nacmacfeegle]

Did it run?

…

On 26 May 2017 19:04, "muscleman" ***@***.***> wrote: I cast routerFunc as and it compiled — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYuyzMRInfjDp-IZ0L8OOctrFICpEQuks5r9xQXgaJpZM4NYGKK> .

[muscleman]

i also had to extract the interfaces Message and Folder into separate ts files and fix where they were referenced. but now i am getting a provider not found issue. Gary

________________________________ From: dan costelloe <[email protected]> Sent: Friday, May 26, 2017 1:05 PM To: ui-router/sample-app-ng2 Cc: muscleman; Comment Subject: Re: [ui-router/sample-app-ng2] webpack: Failed to compile. (in a pure repo clone) (#4) Did it run?

On 26 May 2017 19:04, "muscleman" ***@***.***> wrote: I cast routerFunc as and it compiled — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYuyzMRInfjDp-IZ0L8OOctrFICpEQuks5r9xQXgaJpZM4NYGKK> .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub<#4 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEavE6tU8tprCngRdVKSkq7m3a0VZEkxks5r9xRpgaJpZM4NYGKK>.

[DaSchTour]

@christopherthielen It would help a lot if there was not hard fixed version for @uirouter/core in @uirouter/angular as this also leads to major problems when using JSPM.

[christopherthielen]

@DaSchTour @uirouter/angular should have a hard dependency on @uirouter/core so a given version of @uirouter/angular always behaves the same way.

What problems does this cause for jspm?

[DaSchTour]

@christopherthielen the problem is, that there are different version installed. To have access to uirouter/core functions I have to install it explicitly with JSPM. But this leads to problems because uirouter/angular installs another version and so I have to instances of services and injection fails. So I have tell JSPM which version it should use for all dependencies after every update. Somehow the version and dependency handling of all uirouter modules (core, angular and rx) seams to be very inconsistent and IMHO a bit strange.

[christopherthielen]

To have access to uirouter/core functions I have to install it explicitly with JSPM.

This is surprising to me. The @uirouter/* packages use what I think are typical node dependencies. core has no external deps, angular depends on a specific version of core and rx has a peer dependency on a range of versions of core.

[DaSchTour]

@christopherthielen that's definitely not true. rx for example has rollup as a runtime dependency. So instead of handling core as a dependency JSPM only offers rollup as a dependency.

[christopherthielen]

rx for example has rollup as a runtime dependency.

Ah yes, that's definitely wrong. I see you filed a bug ui-router/rx#5, thanks!

However, the legitimate @uirouter/rx dependencies are alrady listed as peerDependencies. It looks like JSPM supports peer deps. Why doesn't this work?

 "peerDependencies": {
    "@uirouter/core": ">=5.0.0",
    "rxjs": "^5.0.3"
  },

[DaSchTour]

@christopherthielen I really have no idea. But I have no time to test this as we changed our setup. As there are so many obstacles using @angular/router with JSPM I tried to to the migration from uirouter/angularjs to uirouter/angular on JSPM but now we've build up the project from scratch with angular-cli and try to minimize the dependency to 3rd party libraries.