incompatible with React 16 about react-hybrid

[christopherthielen]

This was the key:

react-hybrid/src/angularjs/ReactUIViewAdapterComponent.tsx

Lines 76 to 86 in f61e241

	function renderReactUIView() {
	// console.log(`${$id}: rendering react uiview into container`, el);
	if (destroyed) {
	// console.error(`${$id}: react-ui-view-adapter has already been destroyed -- not rendering React UIView`);
	return;
	}
	const props = { ...attrs, render, wrap: false, refFn: ref };
	// console.log(`${$id}: rendering ReactUIView with props`, props);
	ReactDOM.render<any>(<ReactUIView {...props}/>, el as any);
	}

It was re-rendering the react UIView after the angular adapter had been destroyed.

[hrgui]

That's interesting - because we have React 16 running fine with react-hybrid?

Although there are some unmounting errors, will provide when I come across them again.

[christopherthielen]

I'd like to see those errors.

Here's a stackblitz set up with @uirouter/react-hybrid which shows at least one of the issues I've run across: https://stackblitz.com/edit/ui-router-react-hybrid-respce?file=index.js

[christopherthielen]

I've also added the trivial example to this repo and wired it as an e2e test (yarn test:downstream -- requires yalc installed globally)

[christopherthielen]

Loading #!/angular

[christopherthielen]

going from #!/angular/react to #!/angular

[hrgui]

#12 (comment) is the error that I encountered

I'm wondering if React is asking @ui-router/react-hybrid to do https://reactjs.org/docs/react-dom.html#unmountcomponentatnode on exit?

[hrgui]

Interesting - the ref callback fires again when unMountComponentAtNode is called.

[christopherthielen]

Interesting - the ref callback fires again when unMountComponentAtNode is called.

is that a problem though? It gets called with null right?

[hrgui]

#12 (comment)

Nope, it's not a problem, and yes it gets called with null:
https://github.com/facebook/react/blob/94518b068bf52196abea0c83f4c9926bfe2065c6/packages/react-reconciler/src/ReactFiberCommitWork.js#L136

Seems to be part of React Fiber.