Comments (10)
released in version 6.1.0
from core.
@jpike88 I'm happy to review and merge the PR if you create one :)
from core.
@christopherthielen @ranihorev @wawyed this repo seems almost like it's not being maintained anymore/abandoned.
Could I please kindly have:
- a rough ETA on whether this is going to be addressed, as Ivy has been out for a long time now and this is the only library I have that is still not using Ivy
- if not an ETA, an assurance/expectation that if I create a PR to fix this, it will be merged?
I'm willing to submit a PR to resolve the problem, but we don't want people to start relying on our fixed fork. Your answer will help me decide if the fork needs to be public/private.
Thanks
from core.
I have no clue, to be honest. View Engine is only potentially relevant for Angular 12 and older, with Ivy having become the default in v9 even. All supported Angular versions are now always Ivy, so removing that file will not have any effect for recent versions.
from core.
I'm also struggling with this issue. Can you please update when it is going to be updated to support Ivy partial compilation?
from core.
+1
from core.
+1
from core.
@jpike88 do you know how Angular Compiler determines what exactly should be compiled with ngcc and what is not? ui-router/core
seems not have anything special for angular. It's framework-agnostic. But angular is still trying to compile it anyway. I don't really want to dig into angular compiler sources to understand what causes this package to be compiled, maybe you can point me in the right direction?
from core.
It is because of this file: https://github.com/ui-router/core/blob/306f2b3cfb78b8a81fa47bc40511e83c0ac39161/src/index.metadata.json
That is a View Engine manifest file that ngcc detects. It should be removed to stop ngcc from processing the package, or alternatively this package could add an ngcc.config.js
file next to package.json
:
module.exports = {
entryPoints: {
'.': {
ignore: true
},
}
};
For projects that want to configure this manually, until @uirouter/core
is updated, it's also possible to include ngcc.config.json
in your own project with the following contents:
module.exports = {
packages: {
'@uirouter/core': {
entryPoints: {
'.': {
ignore: true
},
}
}
}
};
from core.
@JoostK Thanks for the explanation. Do you think there is any risk to removing index.metadata.json
?
TBH I have no memory of adding that file 5 years ago, heh.
from core.
Related Issues (20)
- DSR using params subset redirecting to the default state (not sure if anybody is looking on dsr repo) HOT 1
- silenceUncaughtInPromise does not catch onBefore transitions in angular 1.7 HOT 2
- License clash MIT vs CC BY-SA 3.0 HOT 2
- @uirouter/react 0.8.9 not finding UIRouter HOT 1
- Any plan for Svelte 3? HOT 7
- Can't compile angular 8 under typescript "~3.5.3" HOT 3
- Version 6.0.2 breaks using ui-router core on Node.js without a browser HOT 1
- Can't bootstrap a hybrid application in Angular 8 due to commonservices being undefined HOT 6
- string parameters are url encoding issue HOT 5
- is AOT supported? HOT 1
- Ability to set defaultHrefOpts globally HOT 3
- Ugrading to uirouter1.x and installed ui-router-core and ui-router-angularjs ,doesnt support legacy code base HOT 1
- `inherit` is documented as having the wrong default value HOT 1
- Cannot read property 'when' of undefined HOT 19
- Child states their childs, show the parent component HOT 3
- Set uiOptions.reload of [uiSref] to a future load state name lead to error at first load HOT 1
- license issue HOT 1
- How to lazy load with chunks HOT 1
- `ParamDeclaration.inherit = false` is ignored by `$state.href()`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.