Coder Social home page Coder Social logo

Comments (3)

christopherthielen avatar christopherthielen commented on April 27, 2024

Thanks for the detailed description and instructions. I've run into this issue before, and didn't come to an acceptable solution.

ngc relies on Typescript when compiling modules and components. If you step into the ngc code, you will see it ask typescript to process the entry points. Immediately after, the file paths have been resolved to ui-router-core/lib/*. It seems that typescript itself doesn't follow the tsnext/module fields when using moduleResolution: node, although I don't believe they claim to.

I added a mapping to your tsconfig-aot.js which links ui-router-core to the esm code. The code ngc generates now points into ui-router-core/lib-esm/*, but rollup is still adding two copies to the bundle.

  "compilerOptions": {
    "baseUrl": "",
    "target": "es5",
    "module": "es2015",
    "moduleResolution": "node",
    "sourceMap": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": ["es2015", "dom"],
    "noImplicitAny": true,
    "suppressImplicitAnyIndexErrors": true,
    "typeRoots": [
      "./node_modules/@types",
      "./node_modules"
    ],
    "types": [
      "node"
    ],
    "paths": {
      "ui-router-core": ["node_modules/ui-router-core/lib-esm"]
    }
  },

Perhaps this information will help get you past your current block. I can't dig into this further today, but let me know what you come up with.

from angular.

cloudmark avatar cloudmark commented on April 27, 2024

@christopherthielen just checked, it seems that the path does not have any affect on the imports. e.g. in src/client/app/home/home.component.ngfactory.ts the import is still import * as import31 from 'ui-router-core/lib/router';. Are the paths working for you?

from angular.

cloudmark avatar cloudmark commented on April 27, 2024

Looking at the module resolution logs (as we have discussed on Gitter) its looks that the build copies stuff to dist/tmp/. I modified the paths to path resolution to

 "paths": {
      "ui-router-core": ["../../node_modules/ui-router-core/lib-esm"],
      "ui-router-ng2": ["../../node_modules/ui-router-ng2/lib"]
    } 

and it works. If anyone is using the angular-seed https://github.com/mgechev/angular-seed you need to add the above to src/client/tsconfig.json

from angular.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.