Comments (2)
I think we hit the error because the first CentreCount added is for an eliminated power. Because the year is the final year for the game, we set the game to is_finished and save it. That means recalculating the scores for the game, which retrieves the centre counts for the final year from the db, most of which don't exist. The one that does exist is zero, giving a score of 0/0.
We actually don't want to recalculate the scores until we have the centre counts for all 7 powers saved to the database, which I think means setting the game to finished from the view code instead.
The same bug probably exists if somebody solos, and I suspect things wouldn't be correct if there were no eliminated powers, too, although we might not get an exception in that case).
from dipvis.
Fixed by commit 6eabb82
from dipvis.
Related Issues (20)
- Calculate distance travelled to the tournament
- Add support for Circuits HOT 5
- Flag Best Country ties better HOT 9
- New TournamentScoringSystem - best single game score counts HOT 2
- _award_number() must ensure it returns a number <= 12
- Need to speed up generation of CSV files for WDD upload HOT 2
- WDD parsing improvements HOT 1
- Consider storing rank in the database
- Add a page listing awards to add to the WDD
- WDD classification csv wrong for players tied with unranked players
- Filter players out of WDD classification csv
- Player page should distinguish final placings from current
- Support top board sets HOT 3
- Add “best 3 games in any round” TScoringSystem
- Increase max game name length HOT 1
- Game summary page lists shared board tops but not solo board tops HOT 1
- Track destroyed units HOT 1
- Support draw votes that switch to open
- We may now be able to support python 3.12 HOT 1
- Add a "paid" flag to TournamentPlayer HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dipvis.