Comments (5)
Thanks for the detailed report. It's always appreciated to have such reports.
What would you like to have as the error message in Sentry? Sentry message
or INTERNAL_SERVER_ERROR
? Would you like to contribute via PR?
from sentry-dart-tools.
Yup! Happy to contribute a PR. I wanted to check with you on if there is something you were expecting with the current behavior before changing things up.
I think I lean towards having the error.message
show up there, but it's a bit more tricky with an array of errors
. In that case, I'm not sure what message would be best :)
from sentry-dart-tools.
I wanted to check with you on if there is something you were expecting with the current behavior before changing things up.
So far it seems like a case I haven't yet run into.
but it's a bit more tricky with an array of errors
One Sentry event can have multiple exceptions, so multiple GraphQL errors are actually possible from the technical side. Every GraphQL error corresponds to one Sentry exception, and all of those exceptions are sent in one event.
If you want, you can also give input on the following issues in the Sentry repo which are about improved GraphQL support in Sentry:
from sentry-dart-tools.
@ueman I took a deeper look today at my code and as you might have already guessed this was caused by not having a locations
field in our errors
response. I feel like that is an error on our side so maybe there's no change required here.
We could think about what an exception might look like if it's missing the location
information, but I think what you have now works well.
from sentry-dart-tools.
Since Sentry now properly supports GraphQL, I'll close this issue as it is no longer relevant because the way issues are reported will change.
from sentry-dart-tools.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sentry-dart-tools.