Comments (17)
I recently had the same problem and I figured it was because there were edges referencing non-existing nodes. I fixed by filtering the edges_gdf using this line of code:
edges_gdf = edges_gdf[edges_gdf['to'].isin(nodes_gdf['id_node']) & edges_gdf['from'].isin(nodes_gdf['id_node'])]
from pandana.
nodes.set_index('ID', inplace= True)
worked for me, thanks
from pandana.
@wa-bhe , could you set nodes_gdf index to "id_node" then try it again? My understanding is that nodes DF need to be properly indexed to work.
from pandana.
I suggest something to the effect of the following line be added to the network constructor:
assert len((set([i[0] for i in edge_from.index] + [i[1] for i in edge_from.index])) - set(node_x.index)) <= 0, "Error: edges contain unspecified nodes"```
from pandana.
Adding an index as you suggested @semcogli creates a Network dataframe successfully. Many thanks!
nodes_gdf.set_index('id_node', inplace= True)
That does make sense, given that the function is expecting a graph created by osmnet.
I could make a PR on the docs to add a generic geodataframe loading section, specifying that the node layer needs to be indexed by the node id?
from pandana.
The node ids have to be ints, so I'm guessing that for nodes["x"] and/or nodes["y"] the index (not the values) is of type double but should be of type long. Lemme know if that helps.
from pandana.
Thanks for the suggestion, I tested by including:
print(edges.index.dtype)
print(edges["from"].index.dtype)
print(edges["to"].index.dtype)
print(edges["weight"].index.dtype)
print(nodes.index.dtype)
print(nodes["x"].index.dtype)
print(nodes["y"].index.dtype)
And I got int64
printed for all of them. So my dataframe matches the osm_bayarea.h5
for all dtypes for index and columns. However the osm_bayarea.h5
data works fine with pdna.network()
, whereas my dataframe returns the dtype mismatch error.
from pandana.
Hmm, from looking at the code, it's most likely with your edges. You might want to recreate this line of code with your data and see what the type of the resulting index is...
edges_df = pd.DataFrame({'from': edges["from"], 'to': edges["to"]}).join(edge_weights)
from pandana.
Okay I checked it like this:
edge_weights = edges["weight"]
edges_df = pd.DataFrame({'from': edges["from"], 'to': edges["to"]}).join(edge_weights)
print(edges_df.index.dtype)
print(edges_df['from'].index.dtype)
print(edges_df['to'].index.dtype)
print(edge_weights.index.dtype)
Returns int64
for all 4 indexes, this is the same for the osm_bayarea.h5
data too.
The only other thing I can say is different is that the x, y coordinates and weights are just integers turned into floats to fit the API docs (i.e. 486540.0
), but I'm not sure if that relates.
from pandana.
Not sure on this one. My guess is it's something fairly simple we're missing. Might need sample data and sample code to diagnose it...
from pandana.
Agreed, let me do some internal testing with different sample data from different sources (I've only had tried this with the sql derived dataframe) and I'll get back to you either way. Thanks very much for your help!
from pandana.
Hello, I'm having the same issue and just found this thread. Was the problem ever resolved?
from pandana.
@double-u-a we wanted to check in on this to see if you had any updates: #88 (comment) its been awhile.
from pandana.
@sablanchard Yes I have been really meaning to get back to this, we've been busy completely rebuilding our geodatabase so I haven't had the opportunity to create the sample datasets for testing/reproduction of the issue. Fortunately the datasets should be ready in the next week or two. @lmnoel if you have some test data that reproduces the issue already then please do share in the meantime 👍
from pandana.
I'm trying to merge external data with a set of edges/nodes data frames returned from osm.network_from_bbox(), and from my testing, the mere act of concatenating a single row (with each column matching the dtype of the osm.network_from_bbox() DF's precisely) produces this error. @double-u-a @sablanchard
Edit: I think I have solved my issue. It turned out there was an issue with how I was constructing my DF to merge with the osm.network_from_bbox() DF, such that not every node in the edges DF was contained in the nodes DF. An explicit check/warning for this in the Net constructor might be helpful.
from pandana.
Hello, many apologies for the delay in this, I've rebuilt my geodb with fresh data and replicating the error. As per @lmnoel I've done a check to see if my edge and node sets are matching and as far as I can tell the nodes and edges are all matching.
The data is being retrieved from a pgsql db via pandas, and the data types match the example data and what osm.network_from_bbox() builds.
I can confirm running pandas.to_csv and then pandas.read_csv seems to make the dataframe work without error when running pdna.Network, so something in pandas sql derived dataframe is causing an error despite the correct dtypes. At this point it may well be a bug in pandas for all I know.
from pandana.
Hello again!
This problem keeps coming up when I use the library, so I've worked on a self contained example that replicates the error.
Also note deprecation warnings in log at bottom.
# declare graph as dictionary
edge_dict = {
'id': {0: 1, 1: 2, 2: 3, 3: 4, 4: 5},
'id_node_source': {0: 1, 1: 1, 2: 2, 3: 3, 4: 4},
'id_node_target': {0: 4, 1: 2, 2: 4, 3: 4, 4: 2},
'distance': {0: 355.91725215477004,
1: 339.0527044990422,
2: 542.0301068103291,
3: 405.7927520128794,
4: 698.3406580590387}}
node_dict = {
'id_node': {0: 1, 2: 2, 3: 3, 4: 4},
'x': {0: 523991.2039019342,
2: 524221.758848412,
3: 523816.78407285974,
4: 524193.69128971046},
'y': {0: 2944562.7472850494,
2: 2944811.345662121,
3: 2944420.40466592,
4: 2944270.042744304}}
# read dictionary into dataframe
edges_topo = pd.DataFrame.from_dict(edge_dict)
nodes_gdf = pd.DataFrame.from_dict(node_dict)
net = pdna.Network(node_x = nodes_gdf["x"],
node_y = nodes_gdf["y"],
edge_from = edges_topo["id_node_source"],
edge_to = edges_topo["id_node_target"],
edge_weights = edges_topo[["distance"]])
C:\Apps\Anaconda\envs\ium\lib\site-packages\pandana\network.py:82: FutureWarning: Method .as_matrix will be removed in a future version. Use .values instead.
nodes_df.astype('double').as_matrix(),
C:\Apps\Anaconda\envs\ium\lib\site-packages\pandana\network.py:83: FutureWarning: Method .as_matrix will be removed in a future version. Use .values instead.
edges.as_matrix(),
C:\Apps\Anaconda\envs\ium\lib\site-packages\pandana\network.py:85: FutureWarning: Method .as_matrix will be removed in a future version. Use .values instead.
.astype('double')
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
<ipython-input-4-828612a5b386> in <module>
5 edge_from = edges_topo["id_node_source"],
6 edge_to = edges_topo["id_node_target"],
----> 7 edge_weights = edges_topo[["distance"]])
C:\Apps\Anaconda\envs\ium\lib\site-packages\pandana\network.py in __init__(self, node_x, node_y, edge_from, edge_to, edge_weights, twoway)
85 .astype('double')
86 .as_matrix(),
---> 87 twoway)
88
89 self._twoway = twoway
src\cyaccess.pyx in pandana.cyaccess.cyaccess.__cinit__()
ValueError: Buffer dtype mismatch, expected 'long' but got 'double'
from pandana.
Related Issues (20)
- Support for M1 Macs HOT 3
- [Question] How to get different Key|Value combinations in osm.node_query
- [Feature Request] Aggreggation queries to subset of nodes
- Binary incompatibility error with older versions of NumPy HOT 1
- Shortest path length exists but shortest path is empty HOT 5
- shortest path distance between non connected nodes
- Allow specifying mapping distance for POIs
- Issue: the POI Accessibility computation is taking forever
- OSM loader - POIs that are ways in OSM HOT 1
- Pandana network initiation slow for large network HOT 4
- how to increase the performance of the aggregate when impedance is changed to time?
- net.shortest_paths doesn't work with multiprocessing
- tables sub-dependency versions conflict with python 3.10 compatibility when installing with pip HOT 1
- incorrect shortest paths solutions when impendance values are particularly small or large HOT 1
- Plotting with Pandana does not render title HOT 1
- osm.pdna_network_from_bbox error HOT 6
- Pulling network object from OSM bugged HOT 2
- New release ?
- Google Colab install pandana error HOT 1
- query the OSM API for the street network within the specified bounding box error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pandana.