Coder Social home page Coder Social logo

Comments (4)

bill-baumgartner avatar bill-baumgartner commented on August 30, 2024 1

Dear Khoa,
Thank you for your very complete error report. I will look into this and get back to you with a fix.
Best,
Bill

from craft-shared-tasks.

bill-baumgartner avatar bill-baumgartner commented on August 30, 2024

Dear Khoa,

Thank you again for pointing out this issue. I was able to reproduce the error thanks to your very detailed issue report. As you observed, the issue is a results of some improperly formatted discontinuous spans. They are a result of errors in the original coreference annotation. I have updated the evaluation code to address this issue. There is now a validation step at the beginning of the coreference evaluation process that will check both the gold standard and test files for proper discontinuous spans.

Discontinuous spans are validated in two ways. First, if a discontinuous span contains adjacent component spans, e.g. [35..43][44..52], or component spans are are separated by only whitespace, then the component spans are combined, e.g. [35..52]. Second, if the discontinuous span contains a component span that is nested in another component span, e.g. [78..92][88..92], then the nested span is removed, e.g. [78..92].

While fixing issues with the discontinuous spans, I was also able to address an issue whereby annotations of type "nonreferential pronoun" were being output as part of the CoNLL-Coref file format. These annotation types should not have been included, and are now excluded from the output.

I've released an update to the CRAFT corpus that includes the fix to address the issue you reported. Please update to CRAFT v3.1.3, and to the 0.1.2 version of this project. Or, if you are running the evaluations via Docker, please use the ucdenverccp/craft-eval:3.1.3_0.1.2 container which is now available on DockerHub.

Let me know if you continue to experience this issue, or if you have further questions.

Best,
Bill

from craft-shared-tasks.

dnanhkhoa avatar dnanhkhoa commented on August 30, 2024

Dear Bill,

Thank you so much for your time and effort to fix this issue. I will rerun our model on the latest evaluation script and will let you know if there is any problem. Thank you.

Best regards,
Khoa

from craft-shared-tasks.

dnanhkhoa avatar dnanhkhoa commented on August 30, 2024

Now, the latest version works perfectly. Thanks.

from craft-shared-tasks.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.