Comments (20)
I finally added theses following styles
.geosuggest__suggests-wrapper:after {
content: '';
display: block;
background: url('../../assets/images/powered-by-google.png') right center no-repeat white;
background-size: 120px 15px;
border-right: solid 1rem white;
width: 100%;
height: 3rem;
}
from react-geosuggest.
Yep, I thought I'd do it like this
from react-geosuggest.
Of course :)
from react-geosuggest.
Why would this be helpful?
from react-geosuggest.
I thought it would maybe be required by the terms?
https://developers.google.com/places/web-service/policies
from react-geosuggest.
That is correct.
If your application displays Google Places API Web Service data on a page or view that does not also display a Google Map, you must show a "Powered by Google" logo with that data. For example, if your application displays a list of places on one tab, and a Google Map with those places on another tab, the first tab must show the "Powered by Google" logo.
It doesn’t specify to put this in the autosuggest. With a map you don’t need it at all. Would it be a solution to put it somewhere else in your design, not in the autosuggest?
For example, we use it with a map and a license. Don’t need it then.
from react-geosuggest.
Ok, great. Thanks for the clarification.
from react-geosuggest.
You’re welcome! Closing this then.
from react-geosuggest.
Are you sure about this?
If your application displays Google Places API Web Service data on a page or view that does not also display a Google Map, you must show a "Powered by Google" logo with that data
This sounds like it is referring to things like autosuggest boxes. Also, I see most autosuggest packages include the powered by google... although they could be misinterpreting it.
from react-geosuggest.
Yes, as @ro-ka said, this does apply to Geosuggest.
However, the Powered by Google logo does not have to be in the suggest list.
It could be placed elsewhere on your website, and is not required at all under certain circumstances.
It is up to the user of the Geosuggest component to implement proper notices when required.
from react-geosuggest.
I'm currently working on updating this to use the Google Places Details API (to geocode the new Autocomplete place_id
s), which REQUIRES an attribution dom element to be used (presumably for premium results). I could simply create an empty div or something, but I'll probably include it as another prop unless you guys had a preference.
I see both sides of the responsibility argument above. On one hand you want to handle as much for the user as possible and if the goal is to be similar to what users are coming from (whether it's Google's own new google.maps.places.Autocomplete(input)
or other third-party implementations) which include Powered by Google
. On the other hand, the user will still have to update their ToS/Privacy Policy and may in fact want the attribution elsewhere.
I'll try to include minimal changes to the switch-to-place-details PR, but I might include attribution as a separate PR.
from react-geosuggest.
I understand that it is annoying to add it to the suggest list by hand.
What about adding the powered by to the suggest list and allow to hide it via CSS? Or a prop? Would allow to remove it but is there for those who need it.
// cc @yfr
from react-geosuggest.
It's just something we had to do manually after we included the package, but it wasn't that difficult and doesn't seem to be brought up that often so maybe I'm overblowing the issue. I sincerely doubt that Google's going to go after the people that forgot either, so I'm cool with it either. Since I no longer need to do that Place Details PR, I wasn't planning on doing a separate one for adding this either but I'd be willing if there was enough demand.
from react-geosuggest.
Then let’s just wait and see if there is demand. Thanks! 😃
from react-geosuggest.
Hello all, I think we need to have the possibility to add the copyright. We just received a mail by Google with this lines :
In particular, your application also violates clause 9.4(b), which requires developers to include “powered by Google” close to the results of Google Maps API queries where we don’t provide an attribution notice automatically.
Please update your implementation so that “powered by Google” is displayed close to the results, as required by the terms of service.
We’re bringing this to your attention so we can work together to make sure your implementation complies with our terms of service. If you’re not able to bring your implementation into compliance with the terms, we will take action to restrict your access to the service.
from react-geosuggest.
That’s annoying. :/
Can you add the powered by information via CSS to the list? Or position it next to the autocomplete?
from react-geosuggest.
Can you provide some example CSS when you’re done? We could add that to the example.
from react-geosuggest.
Cool, thanks a lot!
from react-geosuggest.
That's cool!
But don't they have a hosted image somewhere on their CDN? Would make it even easier and we could just include it in the defaults.
from react-geosuggest.
I have an alternative setup using an image pulled directly from Google's server. I also put it inside the select menu:
.geosuggest__suggests:after {
content: '';
margin-right: var(--chakra-space-2);
margin-top: var(--chakra-space-2);
height: 18px;
box-sizing: border-box;
text-align: right;
display: block;
background-image: url(https://maps.gstatic.com/mapfiles/api-3/images/powered-by-google-on-white3_hdpi.png);
background-position: right;
background-repeat: no-repeat;
background-size: 120px 14px;
}
from react-geosuggest.
Related Issues (20)
- Billing issues HOT 3
- Expose TypeScript type definitions
- Warning: Prop `aria-owns` did not match. HOT 1
- selectSuggest doesn't trigger onSelectSuggests HOT 3
- Inconsitent suggest.gmaps property received in onSuggestSelect HOT 2
- Test `react-geosuggest` with puppeteer HOT 1
- utc_offset is deprecated as of November 2019 and will beturned off in November 2020. Use utc_offset_minutes instead. HOT 3
- How to allow current location ? and get address based on current location coordinates ? HOT 1
- ul role=listbox should define an aria-label or aria-labelledby HOT 2
- Support React 17 HOT 2
- Selected suggestion didn't apply properly, when searching in Argentina region HOT 1
- Type is invalid - expected a string or a class/function (for composite components) but got: undefined. Check the render method of `Input`. HOT 7
- Google maps API was not found in the page. HOT 2
- Handle the errors returned by the geocoder API
- Label "for" and input "id" do not match
- 'Avnei Hefetz' is an israli settlement city which is not coming in country 'IL' suggestions whereas 'Einav' is also an israli settlement city which is coming in country 'IL' suggestions. HOT 1
- How to detach geocomplete event?
- Using bounds not filtering suggests HOT 1
- Bounds, location, and radius are deprecated
- Support and document loading Maps API via Bootstrap Loader
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-geosuggest.