Comments (6)
@ibgreen is this something you have setup for deck.gl yet?
from nebula.gl.
from nebula.gl.
we recently had a bug in production after featureIndex
was renamed to featureIndexes
. Having correct flow types would have caught it. Would it be possible to prioritize fixing publishing of types (since the codebase already contains them)?
from nebula.gl.
TODO:
- copy / paste the source file and rename each file .js.flow
- add an index.js.flow in dist that points to the source
from nebula.gl.
Some related info:
Old article: https://medium.com/netscape/shipping-flowtype-definitions-in-npm-packages-c987917efb65
Example: https://github.com/uber-web/baseui/blob/master/package.json#L26
from nebula.gl.
@ibgreen is this something you have setup for deck.gl yet?
No. nebula.gl and react-map-gl are the only vis.gl projects that use flow. Other projects like deck.gl have no plans to do so, so those projects would need to "manually" define flow types for consuming applications (something we are interested in but have not gotten around to).
I am actually not sure if react-map-gl is currently taking any steps to publish flow types as part of its npm package, but it would make a lot of sense to 1) publish them and 2) publish the same way in nebula.gl and react-map-gl. @Pessimistress
from nebula.gl.
Related Issues (20)
- Incompatibility between deck.gl and nebula.gl versions during npm install HOT 2
- Significant latency on Windows when drawing shapes from deck8.6/nebula1.x onwards HOT 2
- EditableGeoJsonLayer selected Point Layer able to move, but the the old point still in it place
- MeasureDistanceMode clear measurements
- Wrong position of nodes when modifying LineString HOT 3
- build fails in Vue with TS
- TypeError using with vue
- HtmlOverlay - pure js example HOT 1
- Create & move point on LineString/Polygon incorrectly moves existing point HOT 3
- per expression must either be null or a function HOT 1
- add DrawRectangleByMeasure
- mousemove events while testing in Playwright not having any effect. HOT 1
- Example setup broken in fresh Vite app HOT 1
- Rendering features with EditableGeoJsonLayer gets distorted
- issues with React "react": "^18.2.0", HOT 1
- [Bug] package.json should contain `exports` for usage in NodeJS
- [Bug] imports from sub-paths like `@deck.gl/layers/typed` are not valid
- Typescript error on SelectionLayer
- Add Drag & Draw Rectangle mode HOT 1
- Add CLA requirement to CONTRIBUTING.md HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nebula.gl.