Coder Social home page Coder Social logo

Comments (6)

supersonicclay avatar supersonicclay commented on September 23, 2024

@ibgreen is this something you have setup for deck.gl yet?

from nebula.gl.

georgios-uber avatar georgios-uber commented on September 23, 2024

@romaxa

from nebula.gl.

NameFILIP avatar NameFILIP commented on September 23, 2024

we recently had a bug in production after featureIndex was renamed to featureIndexes. Having correct flow types would have caught it. Would it be possible to prioritize fixing publishing of types (since the codebase already contains them)?

from nebula.gl.

NameFILIP avatar NameFILIP commented on September 23, 2024

TODO:

  • copy / paste the source file and rename each file .js.flow
  • add an index.js.flow in dist that points to the source

from nebula.gl.

NameFILIP avatar NameFILIP commented on September 23, 2024

Some related info:
Old article: https://medium.com/netscape/shipping-flowtype-definitions-in-npm-packages-c987917efb65
Example: https://github.com/uber-web/baseui/blob/master/package.json#L26

from nebula.gl.

ibgreen avatar ibgreen commented on September 23, 2024

@ibgreen is this something you have setup for deck.gl yet?

No. nebula.gl and react-map-gl are the only vis.gl projects that use flow. Other projects like deck.gl have no plans to do so, so those projects would need to "manually" define flow types for consuming applications (something we are interested in but have not gotten around to).

I am actually not sure if react-map-gl is currently taking any steps to publish flow types as part of its npm package, but it would make a lot of sense to 1) publish them and 2) publish the same way in nebula.gl and react-map-gl. @Pessimistress

from nebula.gl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.