Coder Social home page Coder Social logo

Comments (6)

aneeskA avatar aneeskA commented on June 9, 2024 1

Yes, please. What is the meaning of Slack in a leaky bucket algorithm? I have an observation where when the application do not Take() for a period of time, the rate limiting stops to apply on the next Take(). I saw a comment that WithoutSlack is the way to fix this problem. I want to make an educated decision. Please help with some documentation.

from ratelimit.

rabbbit avatar rabbbit commented on June 9, 2024 1

We'll be happy to accept PRs that update the documentation.

from ratelimit.

spencercjh avatar spencercjh commented on June 9, 2024 1

There is a Chinese blog to illustrate slack and #119, #120.

While it partially explains the context of the bug, it still lacks a direct explanation of slack and we are always approaching this issue from an observer's perspective, missing the original author's direct thoughts on this design about slack.

If no one can clarify this, please mention that slack defaults to 10 and the consequences it brings. Even consider modifying the usage example of this library to guide everyone new to use it with ratelimit.WithoutSlack.

If you agree with my comments, I can submit PRs to make contributions.

from ratelimit.

rabbbit avatar rabbbit commented on June 9, 2024 1

Apologies for the delay.

I see the points you're making. If you can put up the PRs, I'll accept them. Please make them small though - one for example, one for the documentation (perhaps in the FAQ)?

Thank you for the Chinese blog post. I'm surprised by the reported performance degradation, I'll try to run some more tests.

from ratelimit.

spencercjh avatar spencercjh commented on June 9, 2024

There was a similar issue about it: #4 .

from ratelimit.

spencercjh avatar spencercjh commented on June 9, 2024

Apologies for the delay.

I see the points you're making. If you can put up the PRs, I'll accept them. Please make them small though - one for example, one for the documentation (perhaps in the FAQ)?

Thank you for the Chinese blog post. I'm surprised by the reported performance degradation, I'll try to run some more tests.

Thanks for your reply. I will try to do some docs works.

from ratelimit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.