Comments (6)
Sweet.
This looks like a really cool tool. cc @Ignas have you seen the jenkins job builder?
No backwards incompatible changes are in the works as far as I know. I'm about to merge #79 which removes the need to have Cobertura installed just to use this plugin, but that's just an internal refactor.
from phabricator-jenkins-plugin.
https://review.openstack.org/#/c/215750/
from phabricator-jenkins-plugin.
@cburroughs thank you for this, I was planning on doing it myself, but you beat me to it!
One question though -quoting your commit message-
NOTE: The plugin also provides a wrapper. The future of that is
unclear time at this time so no jjb support is added.
I've searched the issues on this repo and didn't find any reference on the
wrapper being a WIP/unclear feature. Care to explain this a bit furter?
Once again, thank you for your work.
from phabricator-jenkins-plugin.
Upstream strongly recommends against the arc patch
based approach (the better approaches did not exist when this plugin was first written). I'm not sure it makes sense to encourage arc patch
via the wrapper (It is recommended after all) but there is also very little cost to keeping it around for backwards compatibility while things shake out.
See https://secure.phabricator.com/book/phabricator/article/harbormaster/#change-handoff & https://secure.phabricator.com/T8090
from phabricator-jenkins-plugin.
I agree with your assessment. We'll probably support the wrapper
indefinitely given the migration cost of the job configurations and
harbormaster rules.
But most people should just need the notifier, which has the nice effect of
making this plugin SCM agnostic.
On Wed, Aug 26, 2015 at 4:47 AM cburroughs [email protected] wrote:
Upstream strongly recommends against the arc patch based approach (the
better approaches did not exist when this plugin was first written). I'm
not sure it makes sense to encourage arc patch via the wrapper (It is
recommended after all) but there is also very little cost to keeping it
around for backwards compatibility while things shake out.See
https://secure.phabricator.com/book/phabricator/article/harbormaster/#change-handoff
& https://secure.phabricator.com/T8090—
Reply to this email directly or view it on GitHub
#81 (comment)
.
from phabricator-jenkins-plugin.
@cburroughs should we close this task, or is there more to do?
from phabricator-jenkins-plugin.
Related Issues (20)
- How to create Conduit API token for bot user? HOT 4
- Xml external entity injection
- getbasecommit fail due to sourceControlBaseRevision is null
- Report back build URL immediately with Jeninksfile/pipelines HOT 1
- (Add option to) Fail if git --reset fails HOT 1
- In pipelines, environment variables from withEnv() are ignored
- Should report better cause of failure
- Getting the whole workspace instead of only the diff HOT 1
- Selecting --output json suppresses errors in the configuration HOT 1
- CVEs in the execution path imported by dependencies
- Option to post partial updates and omit pass/fail HOT 3
- [Question] Is it possible to add custom phabricator comment from a jenkins pipeline step? HOT 10
- Fix compatibility with 2.241+ HOT 2
- Release v2.1.4 ? HOT 6
- Improvenents for Documentation HOT 1
- Refactor code coverage logic into independent lib
- [Proposal] Fix bug for instead of overwrite, we should aggregate multiple coverage file coverage line contains same class
- Make processing unit test results optional
- Plug-in still depends on deprecated (and removed) Apache Commons HttpClient HOT 2
- Please make a new release of phabricator-jenkins-plugin HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phabricator-jenkins-plugin.