Coder Social home page Coder Social logo

Comments (6)

ascandella avatar ascandella commented on September 3, 2024

That seems very reasonable. Let's just make it configurable via the
descriptor.
On Mon, Aug 17, 2015 at 7:54 AM Dennis Claassen [email protected]
wrote:

Would it be possible to submit the contents of .phabricator-comment to
Phabricator without the surrounding code block?

We use a lot of custom styling in our messages, that we are currently
sending with a Groovy Postbuild script. Because of the code block, we lose
all of our styling. We would like to use the phabricator comment file,
because currently we need to set up the entire communication with
Phabricator ourselves, which is unnecessary when this plugins provides that
exact functionality.

I'll be able to submit a pull request, but wanted to check if this fix is
something you're willing to accept.


Reply to this email directly or view it on GitHub
#75.

from phabricator-jenkins-plugin.

ascandella avatar ascandella commented on September 3, 2024

@d-claassen were you going to submit a PR or would you like me to implement?

from phabricator-jenkins-plugin.

d-claassen avatar d-claassen commented on September 3, 2024

I would have no idea how to make it configurable. I think it'll be done a lot better when you would implement it ;-)

from phabricator-jenkins-plugin.

ascandella avatar ascandella commented on September 3, 2024

Sounds good. I will add a checkbox to "preserve formatting" that you can enable.

from phabricator-jenkins-plugin.

ascandella avatar ascandella commented on September 3, 2024

This is in master, will be released in 1.8.0 (hopefully this week)

from phabricator-jenkins-plugin.

d-claassen avatar d-claassen commented on September 3, 2024

Nice! Already using it. Thanks for the quick implementation

from phabricator-jenkins-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.