Comments (6)
That seems very reasonable. Let's just make it configurable via the
descriptor.
On Mon, Aug 17, 2015 at 7:54 AM Dennis Claassen [email protected]
wrote:
Would it be possible to submit the contents of .phabricator-comment to
Phabricator without the surrounding code block?We use a lot of custom styling in our messages, that we are currently
sending with a Groovy Postbuild script. Because of the code block, we lose
all of our styling. We would like to use the phabricator comment file,
because currently we need to set up the entire communication with
Phabricator ourselves, which is unnecessary when this plugins provides that
exact functionality.I'll be able to submit a pull request, but wanted to check if this fix is
something you're willing to accept.—
Reply to this email directly or view it on GitHub
#75.
from phabricator-jenkins-plugin.
@d-claassen were you going to submit a PR or would you like me to implement?
from phabricator-jenkins-plugin.
I would have no idea how to make it configurable. I think it'll be done a lot better when you would implement it ;-)
from phabricator-jenkins-plugin.
Sounds good. I will add a checkbox to "preserve formatting" that you can enable.
from phabricator-jenkins-plugin.
This is in master, will be released in 1.8.0 (hopefully this week)
from phabricator-jenkins-plugin.
Nice! Already using it. Thanks for the quick implementation
from phabricator-jenkins-plugin.
Related Issues (20)
- How to create Conduit API token for bot user? HOT 4
- Xml external entity injection
- getbasecommit fail due to sourceControlBaseRevision is null
- Report back build URL immediately with Jeninksfile/pipelines HOT 1
- (Add option to) Fail if git --reset fails HOT 1
- In pipelines, environment variables from withEnv() are ignored
- Should report better cause of failure
- Getting the whole workspace instead of only the diff HOT 1
- Selecting --output json suppresses errors in the configuration HOT 1
- CVEs in the execution path imported by dependencies
- Option to post partial updates and omit pass/fail HOT 3
- [Question] Is it possible to add custom phabricator comment from a jenkins pipeline step? HOT 10
- Fix compatibility with 2.241+ HOT 2
- Release v2.1.4 ? HOT 6
- Improvenents for Documentation HOT 1
- Refactor code coverage logic into independent lib
- [Proposal] Fix bug for instead of overwrite, we should aggregate multiple coverage file coverage line contains same class
- Make processing unit test results optional
- Plug-in still depends on deprecated (and removed) Apache Commons HttpClient HOT 2
- Please make a new release of phabricator-jenkins-plugin HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phabricator-jenkins-plugin.