Comments (1)
See https://docs.github.com/en/free-pro-team@latest/rest/guides/best-practices-for-integrators#favor-asynchronous-work-over-synchronous for their opinions on this. Like slack, we want to respond as soon as possible. Since webhook things usually terminate in less than a second, we shouldn't need to set up async with this. But we still need to change the status codes to be more reflective of intent. Mainly it should reflect whether the webhook event is processed or not.
from rocket2.
Related Issues (20)
- command to export emails of subsets of users HOT 7
- Remove `200` codes from ResponseTuples in function signatures
- Command class functions shouldn't do multiple conflicting things at once, and should delegate to other functions
- team: grant team lead maintainer permissions on github team HOT 2
- Audit broken links in documentation HOT 1
- docs: homepage show wrong header
- team edit: add ability to change github team name
- proposal: secrets management HOT 8
- team: add description property
- proposal: switch PR merge strategy to squashing HOT 6
- move-to-project automation seems to be failing HOT 3
- release process HOT 1
- proposal: admin overview in status page
- Exception initialization is confused
- Auto-generate rocket docs HOT 1
- Failing to deliver a message should fail gracefully
- /rocket i-quit doesn't work
- deploy: certbot renewal requires nginx restart
- Contribution guide link is broken in README
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rocket2.