Comments (2)
RE Configuration Options:
- I don't understand why we would need to specify URLs to receive webhooks (?)
- Domains to accept webhooks should be handled by checking the secret we share with GitHub (when the webhook is created)
- PR and push request will probably be the same event (push to a particular branch) for our purposes. Unless we only want to deploy only when a PR is merged, but not for any push to master (for any sensible setup these will be the same though 🤔)
- I don't think the secret should be a configuration option per se. We should generate it for the user on initialization (there's no reason to make someone generate a random string on their own 😛) and store it to use to check incoming webhooks
RE Configuration Methods:
Why can't the YML just be a part of the repo we're building? Inertia doesn't know exactly how to deploy your repo until it gets the first webhook. If you want to change your deployment strategy, merge a PR with a modified inertia.yml
😀.
I don't agree that we should aim to build in remote interaction. The difference we're looking at is:
With building RPC into Inertia:
inertia <cmd>
Without building RPC into Inertia:
ssh root@box
inertia <cmd>
But with option 1 we need to either use SSH under the hood anyway or implement addressing, transport security, authentication, etc. I don't think our goal should be to avoid requiring ssh. Instead I think our goal should be to do as little as possible while in ssh.
I think having builtin RPC is a nice-to-have neato feature, but I think the costs FAR outweigh the benfits.
from inertia.
Closing since discussion has moved to more specific tickets (ie #67)
from inertia.
Related Issues (20)
- daemon: search and pull docker/compose image instead of hardcoding version
- daemon: enforce project versions serverside HOT 1
- release: inertia v0.6.1
- chore: Archlinux User Repositories release? HOT 1
- chore: automate distribution
- deprecate web app?
- client(bootstrap): pull from github container registry instead of docker hub
- release: inertia v0.6.2
- support workflow where all inertia remote configuration is provided HOT 1
- unclear what to do if login token is expired
- remote login output missing newline
- release: inertia v0.7.0 HOT 1
- test: TestBuilder_Build "type dockerfile" seems flakey HOT 1
- cmd: unify CLI alerts
- medium article: many links are now invalid HOT 1
- docs: CONTRIBUTING.md Development Tips table of contents has strange scope HOT 2
- inertia incorrectly reports upgrade is available HOT 4
- daemon: use standardized docker registry API for `GetLatestImageTag`
- release: inertia v0.7.1
- cmd: mysterious new-line at start of most output HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inertia.