Comments (11)
I see several options:
- use git submodules
- move regexp file to a separated package and add it to composer dependencies.
from uap-php.
π We have a custom bin location, and had to fork and modify the repo to make the download script to work.
from uap-php.
@lucky7id I had a problem with CLI script too but it fixed now (see #7).
from uap-php.
The option I would see is to add a sync job to the command line tool that syncs both test resources and regex.json and also creates the php file and commit all three of them. The benefit is that the package works out of the box, a fact I very much like. What I dislike is the fact that we have to actively release a new version once uap-core is updated. Opinions?
from uap-php.
The composer scheme seems workable. Right now it's a very noticeable pain point among our team, having to update that every time.
from uap-php.
The composer package variant would be even more hassle I suppose. I am thinking about having a cronjob that updates the regex.php nightly, runs the unit tests and automatically commits if the tests passed successfully. If not, manual intervention is needed.
from uap-php.
@lstrojny don't you think that changes of PHP implementation and regexp should be separated?
from uap-php.
@JustBlackBird it would be nicer indeed but we would still need to find a way to auto-update that package whenever uap-core changes + run the tests of uap-php. Given that Iβm not sure itβs worth the trouble.
from uap-php.
@lstrojny may be you are right. I'm only afraid of rapid increasing of the package's patch version.
from uap-php.
@JustBlackBird letβs see how it goes. Closing the issue for now.
from uap-php.
@lstrojny Thank you!
from uap-php.
Related Issues (20)
- Composer bin not working
- Doesn't recognize SRWare Iron HOT 1
- PHP 7.1 support HOT 1
- Did device->family change? HOT 2
- IE Edge identified as Chrome HOT 7
- Compatibility mode detection? HOT 1
- vendor/autoload.php HOT 1
- Make symfony not a required dependency HOT 3
- tag sf4 support please HOT 6
- The list of regexes is outdated HOT 1
- What are libraries for HOT 1
- Adding more custom log readers
- Added typehint to Parser breaks Symfony compiled class HOT 1
- Versioning question HOT 1
- VS Code does not find "parse"-functions HOT 4
- PHP 8.0 compatibility HOT 2
- 'Other' is not returned anymore after updating
- Regexp shipped in this PHP package are outdated HOT 2
- preg_match Warnings After PHP Ugrade HOT 1
- `js_user_agent_string` was removed from uap-core in 2015
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uap-php.