Comments (2)
Hi @martinjras
Without having tested it, it seems like an issue in the underlying regex'es rather than in the c# parser implementation. The NuGet package comes with a specific version of the regex'es available at the time of publishing the NuGet but there is a static overload on the Parser that allows you to push in a newer version.
Try to fetch the newest regex'es from uap-core, they are in a big yaml file, create a parser from that and check if these new regex'es fix the issue. If not, you should open an issue on the uap-core project instead
Hope this helps
from uap-csharp.
Hi @enemaerke ,
Thanks for your response.
I tested it, and you are right. The yaml is basically missing the os_version extract. And also the testcases in test_os.yaml
doesn't specify any versions AT ALL for windows.
Thinking about it, it doesn't make sense at all to try and extract a version-number from the Windows product name. My first thought was to parse it out manually, and thus being able to do < > = operations on the number. But imagine to only allow Windows 8.1 and above to use a website, would then result in Windows 95, 98, 2000 to be
from uap-csharp.
Related Issues (20)
- everything is other HOT 11
- Support for net452+ HOT 5
- Android 9 user agent string not parsing major/minor/patch HOT 1
- Build is still broken HOT 1
- This library is obsolete, move to a new project HOT 4
- ClientInfo UA vs UserAgent HOT 1
- .NET framework 2.0 and earlier are not supported HOT 11
- Pixel 3 XL user agent string not returning correct device information HOT 1
- LinqBridge package is still referenced when targeting .NET 3.5 or later HOT 3
- Expose the engine info HOT 1
- Bounding time spent in regex Match() calls HOT 4
- User agent with parentheses HOT 1
- How to get the type of a device? HOT 2
- Add detection for Edge Chromium HOT 1
- Safari version information supplement HOT 2
- Please add netstandard2.0 target
- Is this a bug? HOT 1
- Handling of empty string replacement values differs between implementations
- NuGet release for .NET Standard 2.0 HOT 1
- Windows 11 Showing as Windows 10 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uap-csharp.