Coder Social home page Coder Social logo

Windows versions about uap-csharp HOT 2 CLOSED

ua-parser avatar ua-parser commented on September 28, 2024
Windows versions

from uap-csharp.

Comments (2)

enemaerke avatar enemaerke commented on September 28, 2024

Hi @martinjras

Without having tested it, it seems like an issue in the underlying regex'es rather than in the c# parser implementation. The NuGet package comes with a specific version of the regex'es available at the time of publishing the NuGet but there is a static overload on the Parser that allows you to push in a newer version.

Try to fetch the newest regex'es from uap-core, they are in a big yaml file, create a parser from that and check if these new regex'es fix the issue. If not, you should open an issue on the uap-core project instead

Hope this helps

from uap-csharp.

martinjras avatar martinjras commented on September 28, 2024

Hi @enemaerke ,
Thanks for your response.
I tested it, and you are right. The yaml is basically missing the os_version extract. And also the testcases in test_os.yaml doesn't specify any versions AT ALL for windows.
Thinking about it, it doesn't make sense at all to try and extract a version-number from the Windows product name. My first thought was to parse it out manually, and thus being able to do < > = operations on the number. But imagine to only allow Windows 8.1 and above to use a website, would then result in Windows 95, 98, 2000 to be 👍 😞

from uap-csharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.