Comments (5)
Thanks, I'll look into it.
from uap-cpp.
I've attempted a fix on this branch: https://github.com/ua-parser/uap-cpp/tree/fix_patch_minor. It requires adding - regex: '(ESPN) Radio (\d+)\.(\d+)\.?(\d+)? rv:(\d+) '
to the upstream regexes.yaml
, alongside the existing - regex: '(ESPN) Radio (\d+)\.(\d+)\.?(\d+)? ?[rv:]?(\d+)? '
, otherwise one of the podcasting_user_agent_strings
tests fails. I'm not sure what flavor of regex is the original one, Boost doesn't consume ?[rv:]?(\d+)?
for ESPN Radio 4.7.4 rv:1032 (iPhone; iPhone OS 9.2.1; en_US)
.
from uap-cpp.
Hmm, do you plan to send a patch on the uap-core with the new regex or a better idea is to have a clone into uap-cpp, or another solution to have a file with this additional regex's and you merge with the core file at runtime?
from uap-cpp.
I think I'll end up asking a question or sending a PR to uap-core, but yes, patching at runtime is the other option.
from uap-cpp.
PR sent: ua-parser/uap-core#305, once it's merged I'll be able to fix this cleanly.
from uap-cpp.
Related Issues (20)
- Is the glog dependency excessive? HOT 2
- Makefile explicitly sets CFLAGS and LDFLAGS HOT 1
- Unexpected `os_v3_replacement` in test HOT 3
- Compiling on Windows [Mingw] HOT 1
- Build error HOT 2
- Features HOT 3
- Compilation fails in Windows with MingW. HOT 3
- Speed Issues HOT 1
- thread safe HOT 2
- uap_core dependency HOT 1
- Support MSVC to build the project HOT 2
- Replace boost-regex with Hyperscan to speed up 40x HOT 5
- Tablet Device Types found for Mobile Devices HOT 1
- gcc (GCC) 4.8.5 can't works HOT 3
- Is this library thread-safe? HOT 1
- undefined reference to `re2::RE2::~RE2()' HOT 1
- Android device type return kDesktop HOT 2
- Request to publish release versions
- consider switching to `FilteredRE2` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uap-cpp.