parsing minor patch seems not working properly about uap-cpp

[asuhan]

Thanks, I'll look into it.

[asuhan]

I've attempted a fix on this branch: https://github.com/ua-parser/uap-cpp/tree/fix_patch_minor. It requires adding - regex: '(ESPN) Radio (\d+)\.(\d+)\.?(\d+)? rv:(\d+) ' to the upstream regexes.yaml, alongside the existing - regex: '(ESPN) Radio (\d+)\.(\d+)\.?(\d+)? ?[rv:]?(\d+)? ', otherwise one of the podcasting_user_agent_strings tests fails. I'm not sure what flavor of regex is the original one, Boost doesn't consume ?[rv:]?(\d+)? for ESPN Radio 4.7.4 rv:1032 (iPhone; iPhone OS 9.2.1; en_US).

[silviucpp]

Hmm, do you plan to send a patch on the uap-core with the new regex or a better idea is to have a clone into uap-cpp, or another solution to have a file with this additional regex's and you merge with the core file at runtime?

[asuhan]

I think I'll end up asking a question or sending a PR to uap-core, but yes, patching at runtime is the other option.

[asuhan]

PR sent: ua-parser/uap-core#305, once it's merged I'll be able to fix this cleanly.