Coder Social home page Coder Social logo

DTriCallback is unused about ode4j HOT 8 CLOSED

tzaeschke avatar tzaeschke commented on May 22, 2024
DTriCallback is unused

from ode4j.

Comments (8)

Gaming32 avatar Gaming32 commented on May 22, 2024

Looking a bit more into this, is this covered by #5?

from ode4j.

tzaeschke avatar tzaeschke commented on May 22, 2024

Yes, it would be covered by #5, except that this is unlikely to happen anytime soon (unless someone volunteers to do it).

Maybe you can use DTriRayCallback instead?

from ode4j.

tzaeschke avatar tzaeschke commented on May 22, 2024

I do not know the reason for this, it maybe an oversight. I think it may be easy to implement. Do you have a good workaround.

While it should be easy to do, it would be another deviation from the original ODE, which I try to keep at a minimum. If you cannot find a good + easy workaround, let me know and we can add it.

from ode4j.

Gaming32 avatar Gaming32 commented on May 22, 2024

I did find a workaround. I separated my existing trimesh into separate trimeshes for each collision type, so I can check which trimesh was collided with to get the collision type, as opposed to looking up the collision type for the specific tri I collide with.

from ode4j.

Gaming32 avatar Gaming32 commented on May 22, 2024

The biggest problem, in my opinion, is that Callback is a required argument for creating a DTriMesh, but then it's unused.

from ode4j.

tzaeschke avatar tzaeschke commented on May 22, 2024

@Gaming32 I implemented a fix + tests, can you have a look whether it works for you? PR: #77

from ode4j.

tzaeschke avatar tzaeschke commented on May 22, 2024

The biggest problem, in my opinion, is that Callback is a required argument for creating a DTriMesh, but then it's unused.

You should be able to use OdeHelper.createTriMesh(space, data, null, null, null);.

from ode4j.

tzaeschke avatar tzaeschke commented on May 22, 2024

Trimesh callbacks have been implemented (except ArrayCallback, which has been deprecated).
OdeHelper now has a method to create trimeshes withou requiring callback arguments.
See PR #77

from ode4j.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.