Cursor in wrong location after inserting `Tabnine` completion items about cmp-tabnine

[yioneko]

Same problem here. I think this is an upstream issue. You can revert to hrsh7th/nvim-cmp@8c08bdf as a temporary workaround. Upstream repo is under refactoring works on async completion, idk whether it's related to this.

[tzachar]

Thanks @yioneko
@mystilleef Does reverting solves you issue?
If so, can you please open an issue in nvim-cmp?
10x.

[tzachar]

Fixed by @hrsh7th in hrsh7th/nvim-cmp@753f5b7

[tzachar]

Feature, not a bug 😄
Every time you see a .. it means its a snippet. The cursor will be placed where the dots indicate, allowing you to fill in the brackets.
You then need to use Tab to navigate to the end of the snippet.

[mystilleef]

Feature, not a bug smile Every time you see a .. it means its a snippet. The cursor will be placed where the dots indicate, allowing you to fill in the brackets. You then need to use Tab to navigate to the end of the snippet.

Yeah, snippet expansion works pretty well. But in my case, that wasn't a snippet expansion. You can see the completion item order.id} does not have a snippet label or placeholder around it. Like you said, snippets are annotated with .. and ~ to indicate snippet expansion. Or maybe I'm missing something?

[mystilleef]

I've added another video showing the problem. You can see when I select the tabnine completion item, cmpapi"), the cursor does not move to the end of the line. You can also see cmpapi") is not a snippet. I'm having this issue when completion items have closing brackets.

Video

t9bug.mp4

[mystilleef]

Thanks @yioneko @mystilleef Does reverting solves you issue? If so, can you please open an issue in nvim-cmp? 10x.

Yes, reverting solves the issue. I'll open an issue at nvim-cmp. Sorry for the trouble, and thanks for your help.

[hrsh7th]

I had allowed calling the callback multiple times by requesting from tzachar.

I think it cmp-tabnine issue. I guess the tabnine source returns invalid completion item.

[tzachar]

@hrsh7th
This has nothing to do with the callback being called multiple times. This behavior was required for cmp-fuzzy-buffer.

Anyway, if reverting nvim-cmp to an earlier revision fixes the problem, it makes more sense that this is a cmp issue.

@mystilleef
Can you send me the output of :messages after applying the following patch?
This can help debugging the isse:

diff --git a/lua/cmp_tabnine/source.lua b/lua/cmp_tabnine/source.lua
index a3b38d2..6c2c426 100644
--- a/lua/cmp_tabnine/source.lua
+++ b/lua/cmp_tabnine/source.lua
@@ -312,4 +312,13 @@ Source._on_stdout = function(_, data, _)
        Source.callback = nil;
 end

+function dump(...)
+    local objects = vim.tbl_map(vim.inspect, {...})
+    print(unpack(objects))
+end
+function Source:resolve(completion_item, callback)
+ dump(completion_item)
+  callback(completion_item)
+end
+
 return Source

[tzachar]

@mystilleef
I bisected the issue to e1f880b7e0ae3cae251fb6c7901bc856fe546e0b in upstream cmp. Please reopen the issue there.

10x.