review stellar-lab-op-duplication about stellar-quest-bounties

[kalepail]

So is this bounty considered complete? Passed by @Kanaye and @apaldiwal? How should we denote agent approval?

There was a suggestion here: #17 (comment).

But maybe better for later submissions? Specifically as this one has no PR against stellar-lab

Let's actually go ahead and submit a PR for this just to see what happens. But I think we should consider this bounty complete once we have a pending PR with Lab. It's probably not a bounty we want to be long lived anyway.

[Kanaye]

Check! Trustlines are authorized now. So you can claim your 2 0x0001f9d0 😄

[Kanaye]

From a UI perspective: I'd love some margin between the "transaction" box and the buttons and between the buttons themselves.

Otherwise it looks good to me 😍

[apaldiwal]

Can we have a consistent shape for the buttons? Other than what Kanaye mentioned, I'm perfectly fine with everything. Good job!

[hanseartic]

Can we have a consistent shape for the buttons? Other than what Kanaye mentioned, I'm perfectly fine with everything. Good job!

I think this way (https://github.com/hanseartic/stellar-laboratory):

it fits better to the order box above.
Whereas this (https://github.com/hanseartic/stellar-laboratory/tree/bounty-no-5-round):

matches the rest of the buttons. I am fine with both.

[kalepail]

But I think we should consider this bounty complete once we have a pending PR with Lab.

Could we agree on which design option to use before raising PR with LAB, please?

This one. Lab team can make the final call if they even decide to accept it. I'd actually like to see icons used. A trash can and the clone icon, but its the functionality that matters most at this point.

[ralphilius]

How/where should we link Stellar public keys? Should they just be linked somewhere in the review issue?

I guess that would be the easiest option for now. But for future it would be easier if we have some kind of "signup" process per hunter that catches that and maybe other stuff like tax-stuff (if we need that, no idea on US law) and so on.

What about a config file in this repo? We should have <GH_USERNAME>:<PUBLIC_KEY> for each line.

[kalepail]

Nice! We're good to close this Issue then yes?

[hanseartic]

From a UI perspective: I'd love some margin between the "transaction" box and the buttons and between the buttons themselves.

Otherwise it looks good to me 😍

see #7 (comment)

[kalepail]

Payment made! Well claimable balance to be specific.
https://stellar.expert/explorer/public/tx/bbb4513f62ba56aee647890201a762e81ea4b9a1c3b2f7cbbd826cfb6dd149b7

Working on the credit payments now. Gotta think through those a little more.

[Kanaye]

Yes, we need auth for that, just tested it as I wasn't sure ;)
Or in other words: my trustline is setup.

[kalepail]

AAAAAgAAAADaswFRJ8wh1zVzSaPvqVm2P0wbRxwYscQsEBrZGtR4xwAAAAACLoovAAAABQAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAIAAAAAAAAAFQAAAACoipMdmCsVBEc1Xlvd2ZxaI3zWkQJa4O8bdYelRngADAAAAAIweDAwMDFmOWQwAAAAAAAA2rMBUSfMIdc1c0mj76lZtj9MG0ccGLHELBAa2RrUeMcAAAAAAAAAAQAAAAAAAAAVAAAAADaiTMqXsd2hgcnmIo6lZhxarAZ6kYgyRBBh/mune9QGAAAAAjB4MDAwMWY5ZDAAAAAAAADaswFRJ8wh1zVzSaPvqVm2P0wbRxwYscQsEBrZGtR4xwAAAAAAAAABAAAAAAAAAAEa1HjHAAAAQMxpqz38WQEFqIyK+hUJx9fGE4ow2+tAwM6pywQmV8FZ6g1jgn5IgBVSV3kZCvKr0/GwW2D9enNtsKHf2HQD2Ak=

Here's the transaction for authorizing the trustlines. You'll just need to wrap in a fee bump before submitting. Also don't run it until @apaldiwal has his trustline setup otherwise it will fail and the sequence number will become invalid and I'll need to regenerate it.

[apaldiwal]

I've set up my trustline! All set and good to go! :)

[apaldiwal]

I agree with you on the first option. It looks much better!

[Kanaye]

I actually like the second variant more.
Yeah the first one looks better, but breaks the design, as all action-buttons are presented round and choices (e.g. <input type="radio"/>-ements are shown more like that , but I'm fine with both variants.

[hanseartic]

Thank you for the feedback. I agree, that from a consistency perspective on UX, the bubbly buttons should be used. But still the stacked buttons feel more space-economic to me.

[kalepail]

So is this bounty considered complete? Passed by @Kanaye and @apaldiwal? How should we denote agent approval?

[hanseartic]

So is this bounty considered complete? Passed by @Kanaye and @apaldiwal? How should we denote agent approval?

There was a suggestion here: #17 (comment).

But maybe better for later submissions? Specifically as this one has no PR against stellar-lab

[hanseartic]

But I think we should consider this bounty complete once we have a pending PR with Lab.

Could we agree on which design option to use before raising PR with LAB, please?

[kalepail]

How/where should we link Stellar public keys? Should they just be linked somewhere in the review issue?

[hanseartic]

How/where should we link Stellar public keys? Should they just be linked somewhere in the review issue?

What about when filing the PR for the submission the feature branch should be named <PUBLIC_KEY>/<ISSUE_ID>?

[Kanaye]

How/where should we link Stellar public keys? Should they just be linked somewhere in the review issue?

I guess that would be the easiest option for now. But for future it would be easier if we have some kind of "signup" process per hunter that catches that and maybe other stuff like tax-stuff (if we need that, no idea on US law) and so on.

[hanseartic]

https://github.com/tyvdh/stellar-quest-bounties/pull/19/files

[kalepail]

Nice!

@Kanaye
@apaldiwal

What about you guys? What address should I create a claimable balance for the agent credits?

[Kanaye]

Right, we should think about how Agents will sign up also 🤔
For now I guess I'll just link it here: GA3KETGKS6Y53IMBZHTCFDVFMYOFVLAGPKIYQMSECBQ7425HPPKANAYE

[apaldiwal]

Oh, here's my public key: GCUIVEY5TAVRKBCHGVPFXXOZTRNCG7GWSEBFVYHPDN2YPJKGPAAAYE4N

[kalepail]

@Kanaye and @apaldiwal I've got your claimable balances issued as well. Once you've setup trustlines I'll need to authorize them before you'll be able to claim I think.

0x0001f9d0:GDNLGAKRE7GCDVZVONE2H35JLG3D6TA3I4OBRMOEFQIBVWI22R4MPIIK

https://stellar.expert/explorer/public/tx/94a368217dda86edc9ee215abe520da9b4861a9a2cf3c20948a546d6e3f1b384

Claimable balances with an auth required asset is an interesting scenario.