review stellar-lab-albedo about stellar-quest-bounties

[kalepail]

1. Can you change 'Albedo' label with 'Wallet' or something similar? I know Albedo isn't technically a wallet, but it will be good to have a generic label.
2. When I click the 'Sign with Albedo' button - can it switch over to a new tab instead of opening a pop up?

Albedo makes sense as it matches the current pattern with Freighter

[kalepail]

@Kanaye
@apaldiwal
Should we consider this bounty complete and ready for payout then? I don't think waiting on PR acceptance in this case is reasonable as the Lab team tends to move slowly.

[Kanaye]

Should we consider this bounty complete and ready for payout then? I don't think waiting on PR acceptance in this case is reasonable as the Lab team tends to move slowly.

Maybe we should think about how we handle this in future. "External" (aka. non-lumenaut) hunters might lose interest on bounties once they've been payed out and don't have interest in resolving issues/feedback from the upstream repository. So maybe we should split bounties with upstream respositories to "X XLM for completing the bounty and Y XLM when the upstream PR gets merged" or something like that.
But I think we're fine here and can consider this bounty completed 👍

[kalepail]

@apaldiwal and @ralphilius can you add your addresses to PRs on this file?
https://github.com/tyvdh/stellar-quest-bounties/blob/main/ADDRESSES.yaml

Thanks!

[Kanaye]

Not sure that it is the greatest idea to open up PRs on the origin repo before we had a chance to review tbh. But well to late, I'll take a look.

[ralphilius]

1. Can you change 'Albedo' label with 'Wallet' or something similar? I know Albedo isn't technically a wallet, but it will be good to have a generic label.
2. When I click the 'Sign with Albedo' button - can it switch over to a new tab instead of opening a pop up?

Albedo makes sense as it matches the current pattern with Freighter

I was just thinking if we end up adding support for more wallets, the UI will get cluttered. But yeah, it makes sense to to match the current pattern.

That's what I originally did until I thought Software Wallets is not a good name, so I sticked with current implementation until we have more integration.

[kalepail]

@ralphilius 48f6df792348da83b7d09cd93b6c239ecfe29f5022b189129533768337ad3695
@Kanaye 803759f86cc13edf7552afe22fc6149050c088fb007c701a47a113f64a8b8b3f
@apaldiwal 327e519f0bd70e94b9ddc4e48b6576a762c2c2a8a33048b54edee6b996fefc1e

[Kanaye]

I guess you've missed a console.log statement from "debugging" https://github.com/stellar/laboratory/pull/546/files#diff-00c0965499c0df35abe501fc79e1b295a7daef567e5b6fdd9f83d7a5654db8feR49

[ralphilius]

I guess you've missed a console.log statement from "debugging" https://github.com/stellar/laboratory/pull/546/files#diff-00c0965499c0df35abe501fc79e1b295a7daef567e5b6fdd9f83d7a5654db8feR49

Yeah.. I missed that. They don't have eslint though 😃

[apaldiwal]

1. Can you change 'Albedo' label with 'Wallet' or something similar? I know Albedo isn't technically a wallet, but it will be good to have a generic label.
2. When I click the 'Sign with Albedo' button - can it switch over to a new tab instead of opening a pop up?

[apaldiwal]

1. Can you change 'Albedo' label with 'Wallet' or something similar? I know Albedo isn't technically a wallet, but it will be good to have a generic label.
2. When I click the 'Sign with Albedo' button - can it switch over to a new tab instead of opening a pop up?

Albedo makes sense as it matches the current pattern with Freighter

I was just thinking if we end up adding support for more wallets, the UI will get cluttered. But yeah, it makes sense to to match the current pattern.

[Kanaye]

Looks good to me! I'd personally replace some of the if-else-if-else-if-statments with switch-statements ... but well they are used that way in other function too, so they kinda belong into the codebase. Also tested the functionallity and other than albedos sometimes weird UI I didn't notice anything 👍

[apaldiwal]

Should we consider this bounty complete and ready for payout then? I don't think waiting on PR acceptance in this case is reasonable as the Lab team tends to move slowly.

Maybe we should think about how we handle this in future. "External" (aka. non-lumenaut) hunters might lose interest on bounties once they've been payed out and don't have interest in resolving issues/feedback from the upstream repository. So maybe we should split bounties with upstream respositories to "X XLM for completing the bounty and Y XLM when the upstream PR gets merged" or something like that.
But I think we're fine here and can consider this bounty completed 👍

I really like this idea!