Comments (19)
This is pretty much completed at this point.
stellar.beign.es runs on the public network, but my dev instance is on the testnet: powerful-everglades-30138.herokuapp.com
from stellar-quest-bounties.
Yes, I think you can do that. 👍
from stellar-quest-bounties.
I checked it out and aside from a few minor issues, I think its good to go.
There are two minor problems:
- the swagger docs is incomplete at some places. It doesn't show the responses that the server sends.
- When posting the xdr, the server responds with response code
201
instead of200
.
There is something else which I'm not sure is a problem:
I am using the Java SDK to verify the challenge tx. Verifying the challenge tx with a muxed account fails with an error saying that the tx is not signed by the server account. This is probably just a bug in the Java SDK though.
from stellar-quest-bounties.
I checked it out and aside from a few minor issues, I think its good to go.
There are two minor problems:
- the swagger docs is incomplete at some places. It doesn't show the responses that the server sends.
- When posting the xdr, the server responds with response code
201
instead of200
.There is something else which I'm not sure is a problem: I am using the Java SDK to verify the challenge tx. Verifying the challenge tx with a muxed account fails with an error saying that the tx is not signed by the server account. This is probably just a bug in the Java SDK though.
There actually was a problem with how my code was handling muxed accounts! I fixed that, and improved the swagger docs to add reponses (including examples)
@rahimklaber Tell me what you think :)
from stellar-quest-bounties.
This Implementation looks really good, the Authentication works fine, the API responses are also all according to Spec. For me, everything worked fine (on testnet). There are good instructions on how to set it up in the Repo, also the Code is very well documented. I also tried your muxed Account fix and indeed it is fixed right and according to Spec. So I think the same as @rahimklaber it is good to go.
from stellar-quest-bounties.
Using Nest JS for this, since I wanted to learn working with it, and it seems like a good fit for this project.
from stellar-quest-bounties.
Added a link to the server (and Swagger API). I'm using heroku free, so the server will shutdown if idle for some time. Should take at most 30 seconds to restart though.
Most functionality is present. Waiting for memo and client_domain support to be added in js-stellar-sdk, but I may decide to implement it on my own if it takes too long.
I've also added a protected endpoint (https://stellar.beign.es/profile) to verify that the JWT token works.
from stellar-quest-bounties.
I've added support for memo/muxed accounts since v9.0.1 of the Stellar JS SDK has been released :)
from stellar-quest-bounties.
client_domain support has been added to the sdk so I'll be able to finish this soon :)
from stellar-quest-bounties.
I've looked at this code, and it looks good. Still would like to look at it a bit deeper. The code installs and runs with a little coercing (probably from windows) I'd like to have some docs on the swagger auth... The end points all seem to work, the details, and stellar.toml endpoint work perfect. I was able to generate a tx on the GET /auth endpoint, but was unable to verify it on the POST /auth after signing it; though maybe I did something wrong. will review further and advise.
from stellar-quest-bounties.
I've looked at this code, and it looks good. Still would like to look at it a bit deeper. The code installs and runs with a little coercing (probably from windows) I'd like to have some docs on the swagger auth... The end points all seem to work, the details, and stellar.toml endpoint work perfect. I was able to generate a tx on the GET /auth endpoint, but was unable to verify it on the POST /auth after signing it; though maybe I did something wrong. will review further and advise.
Has the account you used to generate the challenge funded? My code retrieves the account at verification to check its thresholds, so you'll get an error if the account cannot be found! However, this tells me I should maybe add a specific error message for this situation, since right now it only shows "Signatures are not valid or do not meet the required threshold!" instead of something like "Account cannot be retrieved, make sure it has been funded" or something in that style...
from stellar-quest-bounties.
Trying to verify the challenge tx (with tha java sdk) when using muxed accounts still fails with an exception : Exception in thread "main" org.stellar.sdk.InvalidSep10ChallengeException: Transaction not signed by server: GCQBVSARJXE4MCDOD7CZ2BNIB34KQ7KM4VO3OCHJXCJQW3IOYWOGWDLP.
(with Sep10Challenge.readChallengeTransaction
).
I also tried verifying the signature with KeyPair.verify
which also doesn't work. There is no issue when using normal accounts.
I'll try it in another language, but it will probably be some time. Could someone else try to verify the challenge tx? Not sure if I'm doing something wrong.
from stellar-quest-bounties.
@rahimklaber I don't think the java sdk supports muxed accounts for SEP-10 right now: lightsail-network/java-stellar-sdk#360
from stellar-quest-bounties.
For me it worked with the js sdk.
from stellar-quest-bounties.
Alright, good to go for me then. 👍
from stellar-quest-bounties.
Should I set this to review completed?
from stellar-quest-bounties.
@silence48 I don't see an address for you in the ADDRESSES.yml
file. Can you add one?
from stellar-quest-bounties.
68c15d081c5d06769de2b83779a7baf67b3a19a2a90bf3064af2f002b4bcaebe
from stellar-quest-bounties.
@fpbrault For accounting purposes, what's your Discord user id? If you'd rather not share that here, you can send me a DM on discord. I'm ElliotFriend there 👍🏻
from stellar-quest-bounties.
Related Issues (20)
- Basic Account Viewer by boonku HOT 7
- TypeScript SEP-0010 Server Reference Implementation
- Custom token generator HOT 1
- Tangem XDR Signer HOT 2
- Stellar Account as a Service HOT 7
- Basic Account Viewer by vishwaskamath
- Basic Account Viewer by sohanrai HOT 5
- Basic Account Viewer by Rachanashenoy20 HOT 2
- Basic Account Viewer by vinamogit HOT 11
- basic-account-viewer by orsab HOT 9
- stellar-accounts-as-a-service by orsab HOT 7
- New bounty for Fee Stats in Lab Endpoint Explorer HOT 7
- Bounty Submission: Add Get_Fees to the Stellar Laboratory Endpoints Explorer HOT 2
- claimable-balances-account-viewer by DFugere1 HOT 15
- TipBot HOT 4
- SEP-10 implementation by orsab HOT 4
- JavaScript SEP-0010 Server Reference Implementation by DFugere HOT 2
- Tangem xdr signer
- Tip bot by orsab HOT 9
- Basic account viewer by huuquyet HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stellar-quest-bounties.