Stellar accounts as a service about stellar-quest-bounties

[rahimklaber]

Link in description not working :
https://stellar-wallet.azurewebsites.net

@LorDDark6660 only specific endpoints are accecible. Seems to work fine for me.

[DieKautz]

I looked a bit into your endpoints and your api seems pretty sophisticated 😃

I don't know whether I covered every endpoint and result, but I found two oddities in the /pay endpoint

1. I might triggered a timeout on the /pay endpoint by trying to send less than a stroop to a valid account id.
2. By leaving exactly one stroop in my account I got "5.9604645E-8" as a balance from the /info endpoint and cannot send it to some other account
   Maybe in correlation with that: when sending a significantly small amount compared to the balance it does not get less

ps: kotlin rocks 🚀

[rahimklaber]

@DieKautz Thanks for the feedback.

It should work correctly now. Now, when sending less than a stroop you should get bad request.

Kotlin is awesome indeed.

[DieKautz]

It's fixed as far as I can tell.

The whole application seems very mature as part of this bounty.
I don't know whether its sensible to set no restrictions on usernames and passwords in production, but that shouldn't be a big problem here as this is just an API in in the deeper backend. (in production users would've already been created and handled elsewhere?)

Review criteria from bounty file

endpoints as stated in spec with valid JWT bearer auth

/register

• checking body fields
• checking for already existing users
• checking for sensible input

/login

• recognizing correct credentials
• checking body fields

/info

• returning right users address and balance
• correctly showing external incoming funds
• validating JWT key

/pay

• successfully sending funds to external addresses
• successfully sending funds to other muxed accounts
• checking body fields [x] checking amount (>= 1 stroop & <= balance)
• validating JWT key

Also password are getting stored hashed and avoiding SQL-Injections by using the DSL.

[rahimklaber]

@DieKautz I agree with what you said about the usernames and passwords. I will change it. Thanks.

[rahimklaber]

@DieKautz I finally got around to working on this again. On further thought I agree with you that this server probably shouldn't handle the registration/login. However, I did add a very simple username/password checker that can be extended to support more rigorous checking.

[LorDDark6660]

Link in description not working :
https://stellar-wallet.azurewebsites.net

[kalepail]

559134a441c1251edbd37ae880455a1473a72b1af4d84e3c85f4aa8603fcf103