Coder Social home page Coder Social logo

Comments (6)

pleerock avatar pleerock commented on May 8, 2024 1

new middleware interface signatures are being added in #119

from routing-controllers.

pleerock avatar pleerock commented on May 8, 2024

Not sure what is possible there. I know about this issue with typescript, one solution can be if we create two separate interfaces KoaMiddlewareInterface and ExpressMiddlewareInterface instead of MiddlewareInterface. If you can come to solution with MiddlewareInterface please let me know

from routing-controllers.

JD-Robbs avatar JD-Robbs commented on May 8, 2024

If I can work out a way to keep it all in one interface, I'll let you know. I'll take another look and maybe check if anyone on StackOverlow has any ideas.

from routing-controllers.

marshall007 avatar marshall007 commented on May 8, 2024

@JD-Robbs I was able to get it to compile by overloading the method on my custom class with a more generic signature:

@Middleware()
export class CustomerHeader implements MiddlewareInterface {

  use(request: any, response: any, next?: (err?: any) => any): any;
  use(request: Request, response: Response, next?: NextFunction): any {
    // ...
    next();
  }

}

@pleerock I think if you annotate MiddlewareInterface with the additional overloads it should allow users to implement the method with or without typed parameters.

from routing-controllers.

pleerock avatar pleerock commented on May 8, 2024

middlewares now have separate signatures in 0.7.0

from routing-controllers.

github-actions avatar github-actions commented on May 8, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from routing-controllers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.