Coder Social home page Coder Social logo

Comments (3)

bradzacher avatar bradzacher commented on May 20, 2024

Whats the motivation here? What benefit is there to just using it like this as opposed to just being consistent and treating all imports the same?

I don't see how there's broadly applicable value in being inconsistent and special casing this.

The largest benefit I see in the consistent-type-imports rule is decreasing the amount of cyclic dependencies in the generated code.

I strongly disagree. The benefit is to ensure your imports are properly qualified so that you can leverage non-type-aware transpilers or analysis tools to their fullest.

It allows you to creat self-documenting code that clearly describes the value-domain and type-domain imports.

from typescript-eslint.

kuba-orlik avatar kuba-orlik commented on May 20, 2024

Whats the motivation here? What benefit is there to just using it like this as opposed to just being consistent and treating all imports the same?

If the rule is enforced for all imports, then we get linter warnings on lines like

import {a,b,c,d} from "some-package";

If only some of those imports are for the type, and others for value, then we have to change it to

import type {b,d} from "some-package";
import {a,c} from "some-package";

That's extra work for our team that gives benefits less important (to us!) than what was the intention behind enabling this rule: decreasing cyclic dependencies across our codebase

from typescript-eslint.

bradzacher avatar bradzacher commented on May 20, 2024

That's extra work for our team

But the rule has an autofixer for all cases - so you just run --fix and it fixes everything. So it's the same amount of work if it reports on one or one thousand imports.


The rule isn't intended to do anything around cyclic dependencies. If you're looking to reduce cyclic deps there are separate rules for that.


I don't see any broad applicability here and the motivation does not align with the intent of the rule. Thus I am going to reject this.

from typescript-eslint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.