Comments (3)
Whats the motivation here? What benefit is there to just using it like this as opposed to just being consistent and treating all imports the same?
I don't see how there's broadly applicable value in being inconsistent and special casing this.
The largest benefit I see in the consistent-type-imports rule is decreasing the amount of cyclic dependencies in the generated code.
I strongly disagree. The benefit is to ensure your imports are properly qualified so that you can leverage non-type-aware transpilers or analysis tools to their fullest.
It allows you to creat self-documenting code that clearly describes the value-domain and type-domain imports.
from typescript-eslint.
Whats the motivation here? What benefit is there to just using it like this as opposed to just being consistent and treating all imports the same?
If the rule is enforced for all imports, then we get linter warnings on lines like
import {a,b,c,d} from "some-package";
If only some of those imports are for the type, and others for value, then we have to change it to
import type {b,d} from "some-package";
import {a,c} from "some-package";
That's extra work for our team that gives benefits less important (to us!) than what was the intention behind enabling this rule: decreasing cyclic dependencies across our codebase
from typescript-eslint.
That's extra work for our team
But the rule has an autofixer for all cases - so you just run --fix
and it fixes everything. So it's the same amount of work if it reports on one or one thousand imports.
The rule isn't intended to do anything around cyclic dependencies. If you're looking to reduce cyclic deps there are separate rules for that.
I don't see any broad applicability here and the motivation does not align with the intent of the rule. Thus I am going to reject this.
from typescript-eslint.
Related Issues (20)
- feat(eslint-plugin): remove deprecated no-throw-literal rule
- Docs: Updated typed linting docs for new project service
- Bug: incorrect peer dependencies in v8.0.0-alpha.10 packages HOT 6
- Parser: remove EXPERIMENTAL_useSourceOfProjectReferenceRedirect in favor of project service? HOT 1
- Repo: publishing v8 canary versions failed - "Not Found - PUT https://registry.npmjs.org/@typescript-eslint/types - Not found" HOT 2
- Bug: Broken examples? HOT 1
- Docs: Quickstart guide should be clear on type: module not being a requirement HOT 6
- Repo: Failing to publish new alpha versions of v8 post-v8.0.0-alpha.10 HOT 2
- Bug: [v8.0.0-alpha.10] incorrect error message `Parsing error: "parserOptions.programs"` HOT 1
- Bug: [member-ordering] Not Detecting Order For Read-Only Fields Correctly HOT 1
- Bug: Default configuration following https://typescript-eslint.io/getting-started results in error HOT 1
- Bug(typescript-estree): always parse mts/mjs as ESM for non-type-aware parsing HOT 6
- Docs: Write blog post on the history of ban-types, {}, and object/Object
- Bug: [no-unnecessary-boolean-literal-compare] False positive and unsafe fix with exactOptionalPropertyTypes HOT 6
- Rule proposal: no-unsafe-typeof-function HOT 3
- Types: `plugin` and `parser` types incompatible with ESLint types HOT 6
- Issue with the subDependencies of typescript-eslint HOT 1
- Bug: Type incompatibility with `fixupPluginRules()` from `@eslint/compat` HOT 3
- Bug: parsing a function with argument throws an error when `range` parse option is not set HOT 6
- Bug: [8.0.0-alpha] [no-unused-vars] Support for `ignoreClassWithStaticInitBlock` and `reportUsedIgnorePattern` Options HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript-eslint.